Allow customization of HttpPostProviderFactory via ProfileSyncService

chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc

Index: chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc
diff --git a/chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc b/chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc
index 217ed048bdca546c5c4ea19e1f5c0ab123e8ee0d..2d43fcab56382b897fd6c98858c4a71b97c10daf 100644
--- a/chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc
+++ b/chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc
@@ -19,6 +19,7 @@
 #include "chrome/browser/sync/glue/sync_frontend.h"
 #include "chrome/browser/sync/glue/synced_device_tracker.h"
 #include "chrome/browser/sync/sync_prefs.h"
+#include "chrome/browser/sync/test/test_http_bridge_factory.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/user_prefs/pref_registry_syncable.h"
 #include "content/public/browser/notification_service.h"
@@ -28,6 +29,7 @@
 #include "net/url_request/test_url_fetcher_factory.h"
 #include "sync/internal_api/public/base/model_type.h"
 #include "sync/internal_api/public/engine/model_safe_worker.h"
+#include "sync/internal_api/public/http_post_provider_factory.h"
 #include "sync/internal_api/public/sync_manager_factory.h"
 #include "sync/internal_api/public/test/fake_sync_manager.h"
 #include "sync/internal_api/public/util/experiments.h"
@@ -193,7 +195,9 @@ class SyncBackendHostTest : public testing::Test {
         fake_manager_factory_.PassAs<syncer::SyncManagerFactory>(),
         scoped_ptr<syncer::UnrecoverableErrorHandler>(
             new syncer::TestUnrecoverableErrorHandler).Pass(),
-        NULL);
+        NULL,
+        scoped_ptr<syncer::HttpPostProviderFactory>(

[rlarocque, 2013/11/19 18:41:58]

nit: Are you sure you want to use a test factory here?

I think that using a non-test factory would reduce the overall amount of change
in this CL.  On the other hand, I doubt the HttpPostProviderFactory is actually
used, so you might be fine either way.

[pval...(no longer on Chromium), 2013/11/21 01:32:50]

How would using a non-test factory reduce the amount of code here?

You're right that it's currently not used by FakeSyncManager::Init (where the
HttpPostProviderFactory gets passed). IMO it makes sense to use the
TestHttpBridgeFactory here since this is (supposedly) a unit test and
TestHttpBridgeFactory is essentially a null object
(http://en.wikipedia.org/wiki/Null_Object_pattern). 

+            new TestHttpBridgeFactory()));
     base::RunLoop run_loop;
     BrowserThread::PostDelayedTask(BrowserThread::UI, FROM_HERE,
                                    run_loop.QuitClosure(),