Allow customization of HttpPostProviderFactory via ProfileSyncService

chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/glue/sync_backend_host_impl.h"
 
 #include <cstddef>
 
 #include "base/file_util.h"
 #include "base/location.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/test/test_timeouts.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/invalidation/invalidator_storage.h"
 #include "chrome/browser/prefs/pref_service_syncable.h"
 #include "chrome/browser/sync/glue/device_info.h"
 #include "chrome/browser/sync/glue/sync_frontend.h"
 #include "chrome/browser/sync/glue/synced_device_tracker.h"
 #include "chrome/browser/sync/sync_prefs.h"
+#include "chrome/browser/sync/test/test_http_bridge_factory.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/user_prefs/pref_registry_syncable.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "content/public/test/test_utils.h"
 #include "google/cacheinvalidation/include/types.h"
 #include "net/url_request/test_url_fetcher_factory.h"
 #include "sync/internal_api/public/base/model_type.h"
 #include "sync/internal_api/public/engine/model_safe_worker.h"
+#include "sync/internal_api/public/http_post_provider_factory.h"
 #include "sync/internal_api/public/sync_manager_factory.h"
 #include "sync/internal_api/public/test/fake_sync_manager.h"
 #include "sync/internal_api/public/util/experiments.h"
 #include "sync/notifier/invalidator_state.h"
 #include "sync/protocol/encryption.pb.h"
 #include "sync/protocol/sync_protocol_error.h"
 #include "sync/util/test_unrecoverable_error_handler.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
@@ skipping 145 matching lines @@
     backend_->Initialize(
         &mock_frontend_,
         scoped_ptr<base::Thread>(),
         syncer::WeakHandle<syncer::JsEventHandler>(),
         GURL(std::string()),
         credentials_,
         true,
         fake_manager_factory_.PassAs<syncer::SyncManagerFactory>(),
         scoped_ptr<syncer::UnrecoverableErrorHandler>(
             new syncer::TestUnrecoverableErrorHandler).Pass(),
-        NULL);
+        NULL,
+        scoped_ptr<syncer::HttpPostProviderFactory>(

[rlarocque, 2013/11/19 18:41:58]

nit: Are you sure you want to use a test factory here?

I think that using a non-test factory would reduce the overall amount of change
in this CL.  On the other hand, I doubt the HttpPostProviderFactory is actually
used, so you might be fine either way.

[pval...(no longer on Chromium), 2013/11/21 01:32:50]

How would using a non-test factory reduce the amount of code here?

You're right that it's currently not used by FakeSyncManager::Init (where the
HttpPostProviderFactory gets passed). IMO it makes sense to use the
TestHttpBridgeFactory here since this is (supposedly) a unit test and
TestHttpBridgeFactory is essentially a null object
(http://en.wikipedia.org/wiki/Null_Object_pattern). 

+            new TestHttpBridgeFactory()));
     base::RunLoop run_loop;
     BrowserThread::PostDelayedTask(BrowserThread::UI, FROM_HERE,
                                    run_loop.QuitClosure(),
                                    TestTimeouts::action_timeout());
     run_loop.Run();
     // |fake_manager_factory_|'s fake_manager() is set on the sync
     // thread, but we can rely on the message loop barriers to
     // guarantee that we see the updated value.
     DCHECK(fake_manager_);
   }
@@ skipping 492 matching lines @@
   ASSERT_NE(-1, file_util::WriteFile(sync_file, nonsense, strlen(nonsense)));
 
   InitializeBackend(true);
 
   EXPECT_FALSE(base::PathExists(sync_file));
 }
 
 }  // namespace
 
 }  // namespace browser_sync