Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 737153003: [turbofan]: remove optimization of adds/subs to inc and dec (Closed)

Created:
6 years, 1 month ago by danno
Modified:
6 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan]: remove optimization of adds/subs to inc and dec They generally cause regressions on most modern Intel chips. Replace them with addl/subl. Committed: https://chromium.googlesource.com/v8/v8/+/5492a087ccbf31e408598f1369d93d23d3e52b28

Patch Set 1 #

Patch Set 2 : Whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -82 lines) Patch
M src/compiler/x64/instruction-selector-x64.cc View 1 2 chunks +23 lines, -32 lines 0 comments Download
M test/unittests/compiler/x64/instruction-selector-x64-unittest.cc View 8 chunks +69 lines, -50 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
danno
PTAL
6 years, 1 month ago (2014-11-21 10:02:59 UTC) #2
Benedikt Meurer
LGTM
6 years, 1 month ago (2014-11-21 10:17:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/737153003/20001
6 years, 1 month ago (2014-11-21 12:46:56 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 13:18:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698