Issue 736703002: Take the sk.get out of query-sk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 736703002: Take the sk.get out of query-sk. (Closed)

Created:
6 years, 1 month ago by jcgregorio

Modified:
6 years, 1 month ago

Reviewers:
stephana, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/buildbot@master

Project:
skiabuildbot

Visibility:
Public.

Take the sk.get out of query-sk. Have the params passed into the element via a setParamSet() method. BUG=skia: Committed: https://skia.googlesource.com/buildbot/+/4c53000bb027b3a7536fd9faafbd6f847d32de6f

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -20 lines)			Patch
M	perf/res/imp/query.html	View	1	5 chunks	+9 lines, -20 lines	0 comments	Download
M	perf/res/js/logic.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	perf/templates/clusters.html	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/736703002/20001

6 years, 1 month ago (2014-11-18 13:19:17 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-18 13:19:25 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/buildbot/+/4c53000bb027b3a7536fd9faafbd6f847d32...