Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: perf/res/imp/query.html

Issue 736703002: Take the sk.get out of query-sk. (Closed) Base URL: https://skia.googlesource.com/buildbot@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | perf/res/js/logic.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: perf/res/imp/query.html
diff --git a/perf/res/imp/query.html b/perf/res/imp/query.html
index 40dd1dc995dbba3b010167dc4fd420b01a2f0b11..bd059af0fc4b1c5e9ebfc7e2184e1e3fb13bdec3 100644
--- a/perf/res/imp/query.html
+++ b/perf/res/imp/query.html
@@ -12,16 +12,13 @@
Usage:
- <query-sk scale=0 tile=-1></query-sk>
-
- Attributes:
- scale: The tile scale to use.
- tile: The tile index to use.
+ <query-sk></query-sk>
Properties:
currentQuery: The current URL query formatted selections.
Methods:
+ setParamSet(set): Set the params to be displayed.
clearSelections(): Clear all selections.
Events:
@@ -30,7 +27,7 @@
parameters chosen have changed. The event contains the current
selections formatted as a URL query, found in e.detail.
-->
-<polymer-element name="query-sk" attributes="scale tile">
+<polymer-element name="query-sk">
<template>
<style type="text/css" media="screen">
#more.display {
@@ -101,8 +98,6 @@
Polymer({
created: function() {
- this.paramset = {};
-
// Both primary and secondary are arrays of objects that look like:
//
// {
@@ -118,14 +113,6 @@
ready: function() {
this.currentQuery = '';
- this.tile = this.tile || -1;
- this.scale = this.scale || 0;
-
- // TODO requery when scale or tile attrs change.
- var that = this;
- sk.get('/tiles/0/-1/').then(JSON.parse).then(function(json){
- that.paramset = json.paramset;
- });
this.$.inputs.addEventListener('core-select', this.fireChange.bind(this));
this.$.more.addEventListener('core-select', this.fireChange.bind(this));
@@ -185,19 +172,21 @@
return sel.join('&')
},
- // When paramset changes rebuild the primary and secondary values.
+ // When paramset is changed we rebuild primary and secondary.
//
// The paramset is an object that maps selection names
// to a list of selection values, not necessarily in alphabetical
// order.
- paramsetChanged: function() {
- var keylist = Object.keys(this.paramset).sort();
+ setParamSet: function(paramset) {
+ var keylist = Object.keys(paramset).sort();
+ this.primary = [];
+ this.secondary = [];
for (var i = 0; i < keylist.length; i++) {
var key = keylist[i];
var sel = {
name: key,
- values: this.paramset[key].sort()
+ values: paramset[key].sort()
}
if (whitelist.indexOf(key) != -1) {
this.primary.push(sel);
« no previous file with comments | « no previous file | perf/res/js/logic.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698