Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 736073002: gn win: Various toolchain fixes to get compile working (Closed)

Created:
6 years, 1 month ago by scottmg
Modified:
6 years, 1 month ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gn win: Various toolchain fixes to get compile working This fixes "fatal error C1902: Program database manager mismatch; please check your installation" and "cannot find msvcr120.dll" during gn compilation. There were many things wrong. The primary ones were that: 1) the compiler's setup script wasn't called so we didn't get PATH/LIB/INCLUDE for the correct cl. 2) the VS runtime dirs were not getting added to environment block. I also removed the Express handling, as that's been removed from the gyp path now. This does not yet support a system-installed Visual Studio. Code needs to be added to query the registry to find the install location. (see _SetupScript). R=dpranke@chromium.org TBR=brettw@chromium.org BUG=432375 Committed: https://crrev.com/9bf8fb3b74de68a85122cb45bb477d604b8c3898 Cr-Commit-Position: refs/heads/master@{#304864}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -97 lines) Patch
M build/config/win/BUILD.gn View 3 chunks +1 line, -29 lines 0 comments Download
M build/config/win/visual_studio_version.gni View 3 chunks +3 lines, -12 lines 0 comments Download
M build/toolchain/win/BUILD.gn View 1 chunk +6 lines, -1 line 0 comments Download
M build/toolchain/win/setup_toolchain.py View 1 3 chunks +78 lines, -52 lines 0 comments Download
M build/vs_toolchain.py View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
scottmg
6 years, 1 month ago (2014-11-19 18:29:58 UTC) #1
scottmg
6 years, 1 month ago (2014-11-19 18:30:18 UTC) #3
Dirk Pranke
lgtm. Thanks for working on this! It would've taken me a lot longer ...
6 years, 1 month ago (2014-11-19 18:44:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/736073002/20001
6 years, 1 month ago (2014-11-19 18:50:47 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-19 19:33:37 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 19:34:19 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9bf8fb3b74de68a85122cb45bb477d604b8c3898
Cr-Commit-Position: refs/heads/master@{#304864}

Powered by Google App Engine
This is Rietveld 408576698