build/toolchain/win/BUILD.gn - Issue 736073002: gn win: Various toolchain fixes to get compile working

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/win/BUILD.gn

Issue 736073002: gn win: Various toolchain fixes to get compile working (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/toolchain/win/BUILD.gn

diff --git a/build/toolchain/win/BUILD.gn b/build/toolchain/win/BUILD.gn

index 988683da879abfa15c5372e8d73f0a3dff81c956..87bd254ca8303b4a04e3cb59965ec34e1b9fa2a2 100644

--- a/build/toolchain/win/BUILD.gn

+++ b/build/toolchain/win/BUILD.gn

@@ -16,7 +16,12 @@ assert(is_win)

gyp_win_tool_path = rebase_path("//tools/gyp/pylib/gyp/win_tool.py",

root_build_dir)

exec_script("setup_toolchain.py",

- [ visual_studio_path, gyp_win_tool_path, windows_sdk_path ])

+ [

+ visual_studio_path,

+ gyp_win_tool_path,

+ windows_sdk_path,

+ visual_studio_runtime_dirs

+ ])

# This value will be inherited in the toolchain below.

concurrent_links = exec_script("../get_concurrent_links.py", [], "value")

« no previous file with comments | « build/config/win/visual_studio_version.gni ('k') | build/toolchain/win/setup_toolchain.py » ('j') | no next file with comments »