Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 73603002: Warn user if DART_SDK does not match editor SDK (Closed)

Created:
7 years, 1 month ago by danrubel
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Warn user if DART_SDK does not match editor SDK * show dialog warning user if DART_SDK does not match * remove unused method No longer needed now that DART_SDK references have been removed from all other tools.

Patch Set 1 #

Total comments: 2

Messages

Total messages: 4 (0 generated)
danrubel
7 years, 1 month ago (2013-11-15 02:57:45 UTC) #1
lukechurch
https://codereview.chromium.org/73603002/diff/1/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/DartUIMessages.properties File editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/DartUIMessages.properties (right): https://codereview.chromium.org/73603002/diff/1/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/DartUIMessages.properties#newcode103 editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/DartUIMessages.properties:103: DartSdkInvalid_notEqual=The DART_SDK environment variable references a different SDK than ...
7 years, 1 month ago (2013-11-15 03:19:02 UTC) #2
Brian Wilkerson
LGTM
7 years, 1 month ago (2013-11-15 14:58:31 UTC) #3
pquitslund
7 years, 1 month ago (2013-11-15 18:30:11 UTC) #4
LGTM.  Modulo Luke's refinements (which I like), bombs away!

Powered by Google App Engine
This is Rietveld 408576698