Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 735983002: IDL: Defer typedef resolution (Closed)

Created:
6 years, 1 month ago by bashi
Modified:
6 years, 1 month ago
Reviewers:
haraken, tasak
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: Defer typedef resolution This is a preparation for typedefs visibility change. Since some typedefs are used by more than one interface (e.g. BufferSource), they should be visible from all interfaces when they satisfy the dependencies. Currently, typedef resolution takes place when an IDL file is parsed (in idl_definitions.py). However, not all typedefs are available at that point. This CL defers the typedef resolution at the point the code generator generates bindings code. All typedefs are stored in component_info so that the code generator can refer them. This CL doesn't change the generated code. BUG=425916 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185769

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -47 lines) Patch
M Source/bindings/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download
M Source/bindings/core/v8/generated.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/bindings/modules/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/modules/v8/BUILD.gn View 3 chunks +5 lines, -1 line 0 comments Download
M Source/bindings/modules/v8/generated.gyp View 4 chunks +6 lines, -0 lines 0 comments Download
M Source/bindings/scripts/code_generator_v8.py View 1 4 chunks +8 lines, -5 lines 0 comments Download
M Source/bindings/scripts/compute_interfaces_info_individual.py View 4 chunks +7 lines, -0 lines 0 comments Download
M Source/bindings/scripts/idl_compiler.py View 4 chunks +11 lines, -3 lines 0 comments Download
M Source/bindings/scripts/idl_definitions.py View 4 chunks +8 lines, -15 lines 0 comments Download
M Source/bindings/scripts/scripts.gni View 7 chunks +10 lines, -6 lines 0 comments Download
M Tools/Scripts/webkitpy/bindings/main.py View 7 chunks +12 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
bashi
PTAL? tasak-san, I'd like you to take a look at GYP/GN changes. I want to ...
6 years, 1 month ago (2014-11-19 11:06:35 UTC) #2
bashi
tasak-san, ping?
6 years, 1 month ago (2014-11-20 23:15:30 UTC) #3
tasak
lgtm
6 years, 1 month ago (2014-11-21 02:09:01 UTC) #4
haraken
LGTM https://codereview.chromium.org/735983002/diff/1/Source/modules/crypto/SubtleCrypto.idl File Source/modules/crypto/SubtleCrypto.idl (right): https://codereview.chromium.org/735983002/diff/1/Source/modules/crypto/SubtleCrypto.idl#newcode37 Source/modules/crypto/SubtleCrypto.idl:37: //typedef (ArrayBuffer or ArrayBufferView) CryptoOperationData; On 2014/11/19 11:06:35, ...
6 years, 1 month ago (2014-11-21 02:10:59 UTC) #5
bashi
Thank you for reviews! https://codereview.chromium.org/735983002/diff/1/Source/modules/crypto/SubtleCrypto.idl File Source/modules/crypto/SubtleCrypto.idl (right): https://codereview.chromium.org/735983002/diff/1/Source/modules/crypto/SubtleCrypto.idl#newcode37 Source/modules/crypto/SubtleCrypto.idl:37: //typedef (ArrayBuffer or ArrayBufferView) CryptoOperationData; ...
6 years, 1 month ago (2014-11-21 03:13:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735983002/20001
6 years, 1 month ago (2014-11-21 03:14:41 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/34880)
6 years, 1 month ago (2014-11-21 05:06:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735983002/40001
6 years, 1 month ago (2014-11-21 05:19:49 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 07:24:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185769

Powered by Google App Engine
This is Rietveld 408576698