chrome/browser/password_manager/chrome_password_manager_client.cc - Issue 735733002: PasswordManagerClient::LogSavePasswordProgress should be const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 735733002: PasswordManagerClient::LogSavePasswordProgress should be const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.h ('k') | components/password_manager/core/browser/browser_save_password_progress_logger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/chrome_password_manager_client.cc

diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc

index ab2f0d809b36cca89f7ca3ab0c5df4836e784696..b7be0f4b10f006fb92e9525e810fc4ca9c385cc9 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client.cc

+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc

@@ -275,7 +275,7 @@ void ChromePasswordManagerClient::OnLogRouterAvailabilityChanged(

}

void ChromePasswordManagerClient::LogSavePasswordProgress(

- const std::string& text) {

+ const std::string& text) const {

if (!IsLoggingActive())

return;

PasswordManagerInternalsService* service =