Conditional flags for tests - set JS stack size for simulators.

tools/testrunner/local/testsuite.py

Index: tools/testrunner/local/testsuite.py
diff --git a/tools/testrunner/local/testsuite.py b/tools/testrunner/local/testsuite.py
index 6ff97b34b9e549162f8bebf2bdd23225782ae00e..555c1309be2a21f08c8a6ad47c61fb9a0e90ebad 100644
--- a/tools/testrunner/local/testsuite.py
+++ b/tools/testrunner/local/testsuite.py
@@ -136,6 +136,11 @@ class TestSuite(object):
         t.outcomes = self.rules[testname]
         if statusfile.DoSkip(t.outcomes):
           continue  # Don't add skipped tests to |filtered|.
+        for outc in t.outcomes:

[Jakob Kummerow, 2014/11/19 13:57:15]

nit: no reason to abbreviate, s/outc/outcome/.

[balazs.kilvady, 2014/11/19 16:30:41]

Done.

+          assert type(outc) == str

[Jakob Kummerow, 2014/11/19 13:57:15]

Let's drop the assert (this code is fairly performance sensitive).

[balazs.kilvady, 2014/11/19 16:30:41]

Done.

+          if outc.startswith('Flags: '):
+            (tmp0, tmp1, flags) = outc.partition(':')

[Jakob Kummerow, 2014/11/19 13:57:15]

Suggestion: simplify the body of the if-block to:

t.flags += outcome[7:].split()

Have you tested this patch with the entire "mozilla" test suite? I think you'd
run into
http://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-argum...
for t.flags. Suggested fix: change the default value in TestCase's constructor
to "flags=None", and the initialization line to "self.flags = flags or []".

[balazs.kilvady, 2014/11/19 16:30:41]

Done.

+            t.flags += flags.split()
         flaky = statusfile.IsFlaky(t.outcomes)
         slow = statusfile.IsSlow(t.outcomes)
         pass_fail = statusfile.IsPassOrFail(t.outcomes)