Conditional flags for tests - set JS stack size for simulators.

tools/testrunner/local/testsuite.py

 # Copyright 2012 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
@@ skipping 118 matching lines @@
       slow = False
       pass_fail = False
       testname = self.CommonTestName(t)
       if testname in self.rules:
         used_rules.add(testname)
         # Even for skipped tests, as the TestCase object stays around and
         # PrintReport() uses it.
         t.outcomes = self.rules[testname]
         if statusfile.DoSkip(t.outcomes):
           continue  # Don't add skipped tests to |filtered|.
+        for outc in t.outcomes:

[Jakob Kummerow, 2014/11/19 13:57:15]

nit: no reason to abbreviate, s/outc/outcome/.

[balazs.kilvady, 2014/11/19 16:30:41]

Done.

+          assert type(outc) == str

[Jakob Kummerow, 2014/11/19 13:57:15]

Let's drop the assert (this code is fairly performance sensitive).

[balazs.kilvady, 2014/11/19 16:30:41]

Done.

+          if outc.startswith('Flags: '):
+            (tmp0, tmp1, flags) = outc.partition(':')

[Jakob Kummerow, 2014/11/19 13:57:15]

Suggestion: simplify the body of the if-block to:

t.flags += outcome[7:].split()

Have you tested this patch with the entire "mozilla" test suite? I think you'd
run into
http://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-argum...
for t.flags. Suggested fix: change the default value in TestCase's constructor
to "flags=None", and the initialization line to "self.flags = flags or []".

[balazs.kilvady, 2014/11/19 16:30:41]

Done.

+            t.flags += flags.split()
         flaky = statusfile.IsFlaky(t.outcomes)
         slow = statusfile.IsSlow(t.outcomes)
         pass_fail = statusfile.IsPassOrFail(t.outcomes)
       skip = False
       for rule in self.wildcards:
         assert rule[-1] == '*'
         if testname.startswith(rule[:-1]):
           used_rules.add(rule)
           t.outcomes = self.wildcards[rule]
           if statusfile.DoSkip(t.outcomes):
@@ skipping 112 matching lines @@
     return tests
 
   def GetFlagsForTestCase(self, testcase, context):
     return (testcase.flags + ["--gtest_filter=" + testcase.path] +
             ["--gtest_random_seed=%s" % context.random_seed] +
             ["--gtest_print_time=0"] +
             context.mode_flags)
 
   def shell(self):
     return self.name