Issue 735353002: Tighten up a QUIC LOG(DFATAL) for packets expected to have a non-zero

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 735353002: Tighten up a QUIC LOG(DFATAL) for packets expected to have a non-zero (Closed)

Created:
6 years, 1 month ago by ramant (doing other things)

Modified:
6 years, 1 month ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Use_override_instead_of_virtual_80111599

Project:
chromium

Visibility:
Public.

More Reviews

Description

Tighten up a QUIC LOG(DFATAL) for packets expected to have a non-zero nack count. If the packet is never sent, it never gets nacked, but that wasn't taken into account. Merge internal change: 80120917 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	net/quic/congestion_control/tcp_loss_algorithm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	net/quic/congestion_control/time_loss_algorithm.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages