Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 735353002: Tighten up a QUIC LOG(DFATAL) for packets expected to have a non-zero (Closed)

Created:
6 years, 1 month ago by ramant (doing other things)
Modified:
6 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Use_override_instead_of_virtual_80111599
Project:
chromium
Visibility:
Public.

Description

Tighten up a QUIC LOG(DFATAL) for packets expected to have a non-zero nack count. If the packet is never sent, it never gets nacked, but that wasn't taken into account. Merge internal change: 80120917 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M net/quic/congestion_control/tcp_loss_algorithm.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/time_loss_algorithm.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 1 month ago (2014-11-19 17:46:43 UTC) #1
Ryan Hamilton
6 years, 1 month ago (2014-11-19 17:56:57 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698