net/quic/congestion_control/tcp_loss_algorithm.cc - Issue 735353002: Tighten up a QUIC LOG(DFATAL) for packets expected to have a non-zero

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/congestion_control/tcp_loss_algorithm.cc

Issue 735353002: Tighten up a QUIC LOG(DFATAL) for packets expected to have a non-zero (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Use_override_instead_of_virtual_80111599

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/congestion_control/tcp_loss_algorithm.cc

diff --git a/net/quic/congestion_control/tcp_loss_algorithm.cc b/net/quic/congestion_control/tcp_loss_algorithm.cc

index 6cf56d8f9d42ebe7a667b088593063783ff75665..9366105e82229c04fb1408fe211c1a374a145c94 100644

--- a/net/quic/congestion_control/tcp_loss_algorithm.cc

+++ b/net/quic/congestion_control/tcp_loss_algorithm.cc

@@ -40,7 +40,7 @@ SequenceNumberSet TCPLossAlgorithm::DetectLostPackets(

continue;

}

- LOG_IF(DFATAL, it->nack_count == 0)

+ LOG_IF(DFATAL, it->nack_count == 0 && it->sent_time.IsInitialized())

<< "All packets less than largest observed should have been nacked."

<< "sequence_number:" << sequence_number

<< " largest_observed:" << largest_observed;

« no previous file with comments | « no previous file | net/quic/congestion_control/time_loss_algorithm.cc » ('j') | no next file with comments »