Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 7353017: 2011-07-13: Version 3.4.12 (Closed)

Created:
9 years, 5 months ago by William Hesse
Modified:
9 years, 5 months ago
Reviewers:
Rico
CC:
v8-dev
Visibility:
Public.

Description

Merge changes 8634 and 8636 to trunk. Fix bug in prototype transitions cache clearing introduced by r8165. Invalid loop nesting causes full cleanup of the prototype transitions cache on every GC.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+864 lines, -2770 lines) Patch
M ChangeLog View 1 chunk +16 lines, -0 lines 0 comments Download
M SConstruct View 2 chunks +2 lines, -21 lines 0 comments Download
M include/v8.h View 1 chunk +0 lines, -25 lines 0 comments Download
M src/SConscript View 2 chunks +1 line, -8 lines 0 comments Download
M src/api.cc View 10 chunks +0 lines, -214 lines 0 comments Download
M src/arm/code-stubs-arm.h View 5 chunks +5 lines, -33 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 9 chunks +19 lines, -72 lines 0 comments Download
M src/arm/codegen-arm.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 6 chunks +10 lines, -7 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M src/code-stubs.h View 9 chunks +14 lines, -46 lines 0 comments Download
M src/code-stubs.cc View 4 chunks +45 lines, -19 lines 0 comments Download
M src/codegen.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/conversions.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/cpu-profiler.h View 4 chunks +0 lines, -10 lines 0 comments Download
M src/cpu-profiler.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M src/cpu-profiler-inl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/d8.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/d8.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/debug.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/flag-definitions.h View 2 chunks +1 line, -18 lines 0 comments Download
M src/frames.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/frames.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/handles.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/heap.h View 3 chunks +0 lines, -10 lines 0 comments Download
M src/heap.cc View 14 chunks +13 lines, -61 lines 0 comments Download
M src/heap-profiler.h View 4 chunks +0 lines, -8 lines 0 comments Download
M src/heap-profiler.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 5 chunks +5 lines, -33 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 10 chunks +17 lines, -69 lines 0 comments Download
M src/ia32/codegen-ia32.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 7 chunks +10 lines, -8 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.h View 10 chunks +3 lines, -38 lines 0 comments Download
M src/isolate.cc View 4 chunks +0 lines, -9 lines 0 comments Download
M src/log.h View 6 chunks +3 lines, -13 lines 0 comments Download
M src/log.cc View 35 chunks +3 lines, -129 lines 0 comments Download
M src/log-inl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/log-utils.h View 5 chunks +13 lines, -92 lines 0 comments Download
M src/log-utils.cc View 9 chunks +26 lines, -142 lines 0 comments Download
M src/mark-compact.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/code-stubs-mips.h View 5 chunks +5 lines, -33 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 7 chunks +43 lines, -96 lines 0 comments Download
M src/mips/codegen-mips.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 6 chunks +10 lines, -7 lines 0 comments Download
M src/mksnapshot.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects.cc View 3 chunks +9 lines, -11 lines 0 comments Download
M src/platform.h View 4 chunks +3 lines, -9 lines 0 comments Download
M src/platform-cygwin.cc View 5 chunks +0 lines, -23 lines 0 comments Download
M src/platform-freebsd.cc View 5 chunks +0 lines, -21 lines 0 comments Download
M src/platform-linux.cc View 7 chunks +0 lines, -24 lines 0 comments Download
M src/platform-macos.cc View 5 chunks +0 lines, -19 lines 0 comments Download
M src/platform-nullos.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M src/platform-openbsd.cc View 5 chunks +0 lines, -21 lines 0 comments Download
M src/platform-posix.cc View 3 chunks +14 lines, -1 line 0 comments Download
M src/platform-solaris.cc View 3 chunks +0 lines, -21 lines 0 comments Download
M src/platform-tls.h View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-win32.cc View 4 chunks +18 lines, -22 lines 0 comments Download
M src/profile-generator.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/profile-generator.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/profile-generator-inl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/property.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/proxy.js View 1 chunk +12 lines, -0 lines 0 comments Download
M src/runtime.h View 3 chunks +5 lines, -11 lines 0 comments Download
M src/runtime.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/runtime-profiler.cc View 7 chunks +0 lines, -12 lines 0 comments Download
M src/scopeinfo.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/scopes.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/serialize.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/spaces.h View 12 chunks +1 line, -50 lines 0 comments Download
M src/spaces.cc View 13 chunks +1 line, -80 lines 0 comments Download
M src/spaces-inl.h View 1 chunk +0 lines, -29 lines 0 comments Download
M src/string-stream.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/type-info.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/v8globals.h View 1 chunk +5 lines, -6 lines 0 comments Download
M src/v8natives.js View 7 chunks +31 lines, -6 lines 0 comments Download
M src/v8utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/v8utils.cc View 2 chunks +39 lines, -13 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/vm-state.h View 2 chunks +0 lines, -11 lines 0 comments Download
M src/vm-state-inl.h View 4 chunks +0 lines, -41 lines 0 comments Download
M src/x64/code-stubs-x64.h View 5 chunks +5 lines, -33 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 10 chunks +17 lines, -69 lines 0 comments Download
M src/x64/codegen-x64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 6 chunks +9 lines, -7 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/zone.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/SConscript View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
A + test/cctest/log-eq-of-logging-and-traversal.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M test/cctest/test-lockers.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M test/cctest/test-log.cc View 9 chunks +158 lines, -703 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D test/cctest/test-log-utils.cc View 1 chunk +0 lines, -140 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 2 chunks +0 lines, -4 lines 0 comments Download
A + test/message/regress/regress-1527.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/message/regress/regress-1527.out View 0 chunks +-1 lines, --1 lines 0 comments Download
M test/mjsunit/debug-backtrace.js View 2 chunks +1 line, -2 lines 0 comments Download
M test/mjsunit/harmony/proxies.js View 9 chunks +161 lines, -7 lines 0 comments Download
A + test/mjsunit/regress/regress-88591.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M test/mjsunit/tools/profile_view.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/test262/test262.status View 2 chunks +0 lines, -12 lines 0 comments Download
M tools/codemap.js View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/gcmole/gcmole.lua View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/profile.js View 5 chunks +46 lines, -2 lines 0 comments Download
M tools/splaytree.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
William Hesse
9 years, 5 months ago (2011-07-13 13:04:54 UTC) #1
Rico
9 years, 5 months ago (2011-07-13 13:15:57 UTC) #2
LGTM if commit message does not include date

Powered by Google App Engine
This is Rietveld 408576698