Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: media/blink/buffered_data_source.h

Issue 735143002: Fix race when calling GetWeakPtr() from multiple threads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/blink/buffered_data_source.cc » ('j') | media/blink/buffered_data_source.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/buffered_data_source.h
diff --git a/media/blink/buffered_data_source.h b/media/blink/buffered_data_source.h
index fc462b84ef69cf070bb77fbe07c5e7648fcb585d..85574a1514cce1359ee125c1acb7771531584c2b 100644
--- a/media/blink/buffered_data_source.h
+++ b/media/blink/buffered_data_source.h
@@ -235,6 +235,11 @@ class MEDIA_EXPORT BufferedDataSource : public DataSource {
// NOTE: Weak pointers must be invalidated before all other member variables.
base::WeakPtrFactory<BufferedDataSource> weak_factory_;
+ // Disallow rebinding WeakReference ownership to a different thread by keeping
+ // a persistent reference. This avoids problems with the thread-safety of
+ // reaching into this class from multiple threads to attain a WeakPtr.
+ const base::WeakPtr<BufferedDataSource> weak_ptr_;
+
DISALLOW_COPY_AND_ASSIGN(BufferedDataSource);
};
« no previous file with comments | « no previous file | media/blink/buffered_data_source.cc » ('j') | media/blink/buffered_data_source.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698