media/blink/buffered_data_source.cc - Issue 735143002: Fix race when calling GetWeakPtr() from multiple threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/buffered_data_source.cc

Issue 735143002: Fix race when calling GetWeakPtr() from multiple threads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/blink/buffered_data_source.cc

diff --git a/media/blink/buffered_data_source.cc b/media/blink/buffered_data_source.cc

index 16128f1dd307a44198d2fbb1fcdfda95d16820ac..de115e9b7c4bf3588bb6da16f165c839487f70d9 100644

--- a/media/blink/buffered_data_source.cc

+++ b/media/blink/buffered_data_source.cc

@@ -101,7 +101,8 @@ BufferedDataSource::BufferedDataSource(

media_log_(media_log),

host_(host),

downloading_cb_(downloading_cb),

- weak_factory_(this) {

+ weak_factory_(this),

+ weak_ptr_(weak_factory_.GetWeakPtr()) {

Wez 2014/11/18 23:28:10 You don't seem to be actually referring to this me

DCHECK(host_);

DCHECK(!downloading_cb_.is_null());

}

« media/blink/buffered_data_source.h ('K') | « media/blink/buffered_data_source.h ('k') | no next file » | no next file with comments »