chrome/browser/apps/app_browsertest.cc - Issue 73503005: WindowDotPrintShouldBringUpPrintPreview is consistently failing on official Windows and Linux build…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/app_browsertest.cc

Issue 73503005: WindowDotPrintShouldBringUpPrintPreview is consistently failing on official Windows and Linux build… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/apps/app_browsertest.cc

diff --git a/chrome/browser/apps/app_browsertest.cc b/chrome/browser/apps/app_browsertest.cc

index ed2ceb71a405641d34aa49f9071ebb6c474dbdca..2a2a5bac6afefe4317685339a98451e131b9ea44 100644

--- a/chrome/browser/apps/app_browsertest.cc

+++ b/chrome/browser/apps/app_browsertest.cc

@@ -1116,7 +1116,8 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MAYBE_WebContentsHasFocus) {

// <path-to-your-src>/out/Debug/Chromium.app/*/*/*/*/"Internet Plug-Ins"

// 4) Run browser_tests with the --enable-print-preview flag

-#if !defined(GOOGLE_CHROME_BUILD)

+#if !defined(GOOGLE_CHROME_BUILD) || \

+ (defined(GOOGLE_CHROME_BUILD) && (defined(OS_WIN) || defined(OS_LINUX)))

#define MAYBE_WindowDotPrintShouldBringUpPrintPreview \

DISABLED_WindowDotPrintShouldBringUpPrintPreview

#else

« no previous file with comments | « no previous file | no next file » | no next file with comments »