Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: chrome/browser/apps/app_browsertest.cc

Issue 73503005: WindowDotPrintShouldBringUpPrintPreview is consistently failing on official Windows and Linux build… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "apps/launcher.h" 5 #include "apps/launcher.h"
6 #include "apps/shell_window.h" 6 #include "apps/shell_window.h"
7 #include "apps/shell_window_registry.h" 7 #include "apps/shell_window_registry.h"
8 #include "apps/ui/native_app_window.h" 8 #include "apps/ui/native_app_window.h"
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 1098 matching lines...) Expand 10 before | Expand all | Expand 10 after
1109 // 2) Build Chromium browser_tests 1109 // 2) Build Chromium browser_tests
1110 // 3) Make a copy of the PDF plug-in from a recent version of Chrome (Canary 1110 // 3) Make a copy of the PDF plug-in from a recent version of Chrome (Canary
1111 // or a recent development build) to your Chromium build: 1111 // or a recent development build) to your Chromium build:
1112 // - On Linux and Chrome OS, copy /opt/google/chrome/libpdf.so to 1112 // - On Linux and Chrome OS, copy /opt/google/chrome/libpdf.so to
1113 // <path-to-your-src>/out/Debug 1113 // <path-to-your-src>/out/Debug
1114 // - On OS X, copy PDF.plugin from 1114 // - On OS X, copy PDF.plugin from
1115 // <recent-chrome-app-folder>/*/*/*/*/"Internet Plug-Ins" to 1115 // <recent-chrome-app-folder>/*/*/*/*/"Internet Plug-Ins" to
1116 // <path-to-your-src>/out/Debug/Chromium.app/*/*/*/*/"Internet Plug-Ins" 1116 // <path-to-your-src>/out/Debug/Chromium.app/*/*/*/*/"Internet Plug-Ins"
1117 // 4) Run browser_tests with the --enable-print-preview flag 1117 // 4) Run browser_tests with the --enable-print-preview flag
1118 1118
1119 #if !defined(GOOGLE_CHROME_BUILD) 1119 #if !defined(GOOGLE_CHROME_BUILD) || \
1120 (defined(GOOGLE_CHROME_BUILD) && (defined(OS_WIN) || defined(OS_LINUX)))
1120 #define MAYBE_WindowDotPrintShouldBringUpPrintPreview \ 1121 #define MAYBE_WindowDotPrintShouldBringUpPrintPreview \
1121 DISABLED_WindowDotPrintShouldBringUpPrintPreview 1122 DISABLED_WindowDotPrintShouldBringUpPrintPreview
1122 #else 1123 #else
1123 #define MAYBE_WindowDotPrintShouldBringUpPrintPreview \ 1124 #define MAYBE_WindowDotPrintShouldBringUpPrintPreview \
1124 WindowDotPrintShouldBringUpPrintPreview 1125 WindowDotPrintShouldBringUpPrintPreview
1125 #endif 1126 #endif
1126 1127
1127 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, 1128 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,
1128 MAYBE_WindowDotPrintShouldBringUpPrintPreview) { 1129 MAYBE_WindowDotPrintShouldBringUpPrintPreview) {
1129 ScopedPreviewTestingDelegate preview_delegate(true); 1130 ScopedPreviewTestingDelegate preview_delegate(true);
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
1303 false); 1304 false);
1304 ASSERT_TRUE(restart_requested_listener.WaitUntilSatisfied()); 1305 ASSERT_TRUE(restart_requested_listener.WaitUntilSatisfied());
1305 1306
1306 EXPECT_EQ(1, request_restart_call_count()); 1307 EXPECT_EQ(1, request_restart_call_count());
1307 } 1308 }
1308 1309
1309 #endif // defined(OS_CHROMEOS) 1310 #endif // defined(OS_CHROMEOS)
1310 1311
1311 1312
1312 } // namespace extensions 1313 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698