Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7349021: Convert some more view methods to the ui/views style. (Closed)

Created:
9 years, 5 months ago by Ben Goodger (Google)
Modified:
9 years, 5 months ago
CC:
chromium-reviews, Paweł Hajdan Jr., dhollowa
Visibility:
Public.

Description

Convert some more view methods to the ui/views style. BUG=72040 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92705

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -168 lines) Patch
M chrome/browser/chromeos/login/eula_view.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/views_oobe_display.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/notifications/balloon_view.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/notifications/notification_panel.cc View 1 2 3 4 6 chunks +8 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/status/status_area_view.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/touch/frame/keyboard_container_view.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/accessibility_event_router_views.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc View 1 2 3 4 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/autocomplete/touch_autocomplete_popup_contents_view.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 2 3 4 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc View 1 2 3 4 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/bubble/bubble.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_frame.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_gtk.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.cc View 1 2 3 4 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobar_container_view.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/wrench_menu.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/interactive_ui/view_event_test_base.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M views/accessibility/native_view_accessibility_win.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M views/controls/menu/menu_controller.cc View 1 2 3 4 2 chunks +3 lines, -5 lines 0 comments Download
M views/controls/menu/menu_item_view.cc View 1 2 3 4 7 chunks +7 lines, -7 lines 0 comments Download
M views/controls/menu/menu_scroll_view_container.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/submenu_view.cc View 1 2 3 4 4 chunks +5 lines, -5 lines 0 comments Download
M views/controls/scroll_view.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M views/controls/single_split_view.cc View 1 2 3 4 5 chunks +11 lines, -12 lines 0 comments Download
M views/controls/single_split_view_unittest.cc View 1 2 3 4 2 chunks +7 lines, -7 lines 0 comments Download
M views/controls/tabbed_pane/native_tabbed_pane_gtk.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M views/controls/tabbed_pane/native_tabbed_pane_win.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M views/controls/textfield/native_textfield_win.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M views/examples/scroll_view_example.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M views/examples/throbber_example.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M views/examples/widget_example.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M views/focus/focus_search.cc View 1 2 3 4 3 chunks +4 lines, -6 lines 0 comments Download
M views/layout/box_layout.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M views/layout/fill_layout.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M views/layout/grid_layout_unittest.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M views/view.h View 1 2 3 4 2 chunks +13 lines, -5 lines 0 comments Download
M views/view.cc View 1 2 3 4 20 chunks +22 lines, -37 lines 0 comments Download
M views/widget/root_view.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
9 years, 5 months ago (2011-07-13 23:31:48 UTC) #1
sky
LGTM http://codereview.chromium.org/7349021/diff/7004/views/view.cc File views/view.cc (right): http://codereview.chromium.org/7349021/diff/7004/views/view.cc#newcode1133 views/view.cc:1133: if (!child) { This 'if' no longer makes ...
9 years, 5 months ago (2011-07-13 23:54:52 UTC) #2
commit-bot: I haz the power
9 years, 5 months ago (2011-07-14 00:00:27 UTC) #3 
Can't apply patch for file views/view.cc.
While running patch -p0 --forward --force;
patching file views/view.cc
Hunk #4 FAILED at 609.
1 out of 20 hunks FAILED -- saving rejects to file views/view.cc.rej

Powered by Google App Engine
This is Rietveld 408576698