Convert some more view methods to the ui/views style.

views/view.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VIEWS_VIEW_H_
 #define VIEWS_VIEW_H_
 #pragma once
 
 #include <algorithm>
 #include <map>
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/i18n/rtl.h"
+#include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "build/build_config.h"
 #include "ui/base/dragdrop/os_exchange_data.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/gfx/rect.h"
 #include "views/accelerator.h"
 #include "views/background.h"
 #include "views/border.h"
 #include "views/layer_helper.h"
 
@@ skipping 103 matching lines @@
   // the view at the end.
   void ReorderChildView(View* view, int index);
 
   // Removes |view| from this view. The view's parent will change to NULL.
   void RemoveChildView(View* view);
 
   // Removes all the children from this view. If |delete_children| is true,
   // the views are deleted, unless marked as not parent owned.
   void RemoveAllChildViews(bool delete_children);
 
-  // Returns the child view at |index|.
-  const View* GetChildViewAt(int index) const;
-  View* GetChildViewAt(int index);
-
-  // Returns the number of child views.
+  // STL-style accessors.
+  Views::const_iterator children_begin() { return children_.begin(); }

[sky, 2011/07/13 23:54:52]

can these 4 be const?

+  Views::const_iterator children_end() { return children_.end(); }
+  Views::const_reverse_iterator children_rbegin() { return children_.rbegin(); }
+  Views::const_reverse_iterator children_rend() { return children_.rend(); }
   int child_count() const { return static_cast<int>(children_.size()); }
   bool has_children() const { return !children_.empty(); }
+  View* child_at(int index) {
+    DCHECK_LT(index, child_count());
+    return children_[index];
+  }
+  const View* child_at(int index) const {
+    return const_cast<View*>(const_cast<const View*>(this))->child_at(index);
+  }
 
   // Returns the parent view.
   const View* parent() const { return parent_; }
   View* parent() { return parent_; }
 
   // Returns true if |view| is contained within this View's hierarchy, even as
   // an indirect descendant. Will return true if child is also this view.
   bool Contains(const View* view) const;
 
   // Returns the index of |view|, or -1 if |view| is not a child of this view.
@@ skipping 1267 matching lines @@
 #if defined(OS_WIN)
   scoped_refptr<NativeViewAccessibilityWin> native_view_accessibility_win_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(View);
 };
 
 }  // namespace views
 
 #endif  // VIEWS_VIEW_H_