Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 7347011: Update URLPatternSet to contain a std::set instead of std::vector. (Closed)

Created:
9 years, 5 months ago by jstritar
Modified:
9 years, 5 months ago
CC:
chromium-reviews, kkania, Erik does not do reviews, brettw-cc_chromium.org, achuith+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Update URLPatternSet to contain a std::set instead of std::vector. This updates URLPatternSet to contain a std::set instead of a std::vector, making it easier to implement the set operations in ExtensionPermissionSet. BUG=84507 TEST=unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92364

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Fix windows compile errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+428 lines, -351 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/convert_user_script.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/convert_user_script_unittest.cc View 3 chunks +17 lines, -5 lines 0 comments Download
M chrome/browser/extensions/convert_web_app_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 2 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_management_api.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 1 2 5 chunks +19 lines, -35 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 7 chunks +16 lines, -36 lines 0 comments Download
M chrome/browser/extensions/user_script_master.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/user_script_master_unittest.cc View 3 chunks +16 lines, -7 lines 0 comments Download
M chrome/common/extensions/extension.h View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/common/extensions/extension.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/extension_manifests_unittest.cc View 5 chunks +18 lines, -9 lines 0 comments Download
M chrome/common/extensions/extension_messages.cc View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/common/extensions/extension_permission_set.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/extension_permission_set.cc View 1 10 chunks +34 lines, -36 lines 0 comments Download
M chrome/common/extensions/extension_permission_set_unittest.cc View 17 chunks +37 lines, -54 lines 0 comments Download
M chrome/common/extensions/extension_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/file_browser_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/url_pattern.h View 1 2 5 chunks +26 lines, -33 lines 0 comments Download
M chrome/common/extensions/url_pattern.cc View 7 chunks +45 lines, -5 lines 0 comments Download
M chrome/common/extensions/url_pattern_set.h View 1 2 3 chunks +11 lines, -4 lines 0 comments Download
M chrome/common/extensions/url_pattern_set.cc View 1 2 4 chunks +21 lines, -19 lines 0 comments Download
M chrome/common/extensions/url_pattern_set_unittest.cc View 3 chunks +2 lines, -23 lines 0 comments Download
M chrome/common/extensions/url_pattern_unittest.cc View 1 chunk +94 lines, -0 lines 0 comments Download
M chrome/common/extensions/user_script.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/common/extensions/user_script.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/user_script_unittest.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/renderer/extensions/extension_dispatcher.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/renderer/extensions/user_script_slave.cc View 3 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jstritar
9 years, 5 months ago (2011-07-12 16:19:46 UTC) #1
Matt Perry
LGTM
9 years, 5 months ago (2011-07-12 18:50:13 UTC) #2
commit-bot: I haz the power
9 years, 5 months ago (2011-07-12 19:38:32 UTC) #3
Change committed as 92219

Powered by Google App Engine
This is Rietveld 408576698