Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3151)

Unified Diff: chrome/common/extensions/user_script_unittest.cc

Issue 7347011: Update URLPatternSet to contain a std::set instead of std::vector. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix windows compile errors. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/user_script.cc ('k') | chrome/renderer/extensions/extension_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/user_script_unittest.cc
diff --git a/chrome/common/extensions/user_script_unittest.cc b/chrome/common/extensions/user_script_unittest.cc
index c04e54dc9ac28637c03e97ee8e3db8353ced27a6..f3eb5fef0fee8979ceec23c969ab38cf7573ecf4 100644
--- a/chrome/common/extensions/user_script_unittest.cc
+++ b/chrome/common/extensions/user_script_unittest.cc
@@ -208,11 +208,8 @@ TEST(ExtensionUserScriptTest, Pickle) {
for (size_t i = 0; i < script1.globs().size(); ++i) {
EXPECT_EQ(script1.globs()[i], script2.globs()[i]);
}
- ASSERT_EQ(script1.url_patterns().size(), script2.url_patterns().size());
- for (size_t i = 0; i < script1.url_patterns().size(); ++i) {
- EXPECT_EQ(script1.url_patterns()[i].GetAsString(),
- script2.url_patterns()[i].GetAsString());
- }
+
+ ASSERT_EQ(script1.url_patterns(), script2.url_patterns());
}
TEST(ExtensionUserScriptTest, Defaults) {
« no previous file with comments | « chrome/common/extensions/user_script.cc ('k') | chrome/renderer/extensions/extension_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698