Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 734603004: Fix Zlib Win GN build after https://codereview.chromium.org/742583003 (Closed)

Created:
6 years, 1 month ago by jam
Modified:
6 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix Zlib Win GN build after https://codereview.chromium.org/742583003 Committed: https://crrev.com/9c3285ebf6bd7ecbdc5b68892c50be394f63ffd6 Cr-Commit-Position: refs/heads/master@{#304859}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/zlib/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
jam
6 years, 1 month ago (2014-11-19 17:28:34 UTC) #2
Nico
lgtm, thanks
6 years, 1 month ago (2014-11-19 17:34:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/734603004/1
6 years, 1 month ago (2014-11-19 18:42:48 UTC) #5
scottmg
Ah, was just trying to figure this out, thanks!
6 years, 1 month ago (2014-11-19 19:00:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-19 19:23:25 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 19:24:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c3285ebf6bd7ecbdc5b68892c50be394f63ffd6
Cr-Commit-Position: refs/heads/master@{#304859}

Powered by Google App Engine
This is Rietveld 408576698