Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Issue 742583003: Fix fallout from https://codereview.chromium.org/678423002/ (Closed)

Created:
6 years, 1 month ago by Nico
Modified:
6 years, 1 month ago
Reviewers:
Dirk Pranke, hans
CC:
chromium-reviews, robert.bradford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix fallout from https://codereview.chromium.org/678423002/ * Let BUILD.gn build the same files on Windows as the gyp file does. * Remove -msse2 flag, that's on globally * On win/clang, pass -msse4.2 -mclmul flags to fix clang/wi complaining about unsupported intrinsics BUG=82385 R=dpranke@chromium.org, hans@chromium.org TBR=brettw Committed: https://crrev.com/f3b5bb2d25abb3bacb246531b6cfa6d36abb17b2 Cr-Commit-Position: refs/heads/master@{#304695}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M third_party/zlib/BUILD.gn View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/zlib/zlib.gyp View 1 chunk +17 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Nico
dpranke: gn change hans: gyp change
6 years, 1 month ago (2014-11-18 22:58:22 UTC) #2
Dirk Pranke
lgtm
6 years, 1 month ago (2014-11-18 23:03:01 UTC) #3
hans
lgtm
6 years, 1 month ago (2014-11-18 23:06:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742583003/1
6 years, 1 month ago (2014-11-18 23:09:49 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f3b5bb2d25abb3bacb246531b6cfa6d36abb17b2 Cr-Commit-Position: refs/heads/master@{#304695}
6 years, 1 month ago (2014-11-18 23:22:48 UTC) #7
Nico
6 years, 1 month ago (2014-11-18 23:22:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f3b5bb2d25abb3bacb246531b6cfa6d36abb17b2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698