Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 734313004: Move InlineTextBox::rotation to TextPainter (Closed)

Created:
6 years, 1 month ago by fs
Modified:
6 years, 1 month ago
Reviewers:
pdr., slimming-paint-reviews
CC:
blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Move InlineTextBox::rotation to TextPainter This helper method is static and only used from (text) paint(ing) code. BUG=412088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185558

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M Source/core/paint/EllipsisBoxPainter.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/paint/InlineTextBoxPainter.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/core/paint/TextPainter.h View 3 chunks +11 lines, -0 lines 0 comments Download
M Source/core/paint/TextPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/InlineTextBox.h View 3 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
fs
6 years, 1 month ago (2014-11-18 17:33:09 UTC) #2
pdr.
lgtm
6 years, 1 month ago (2014-11-18 18:33:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/734313004/1
6 years, 1 month ago (2014-11-18 18:34:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/37110)
6 years, 1 month ago (2014-11-18 20:05:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/734313004/1
6 years, 1 month ago (2014-11-18 20:07:37 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/37123)
6 years, 1 month ago (2014-11-18 20:34:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/734313004/1
6 years, 1 month ago (2014-11-18 21:15:04 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/37145)
6 years, 1 month ago (2014-11-18 21:51:30 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/734313004/1
6 years, 1 month ago (2014-11-18 23:18:49 UTC) #18
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 00:06:51 UTC) #19
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185558

Powered by Google App Engine
This is Rietveld 408576698