Chromium Code Reviews Chromium Code Reviews
Issue 734243003:
Adding the chrome://copresence page (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@state| Index: chrome/browser/resources/copresence.html |
| diff --git a/chrome/browser/resources/copresence.html b/chrome/browser/resources/copresence.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..77c4e077542135fefbbf79aba4adb4ea7e081200 |
| --- /dev/null |
| +++ b/chrome/browser/resources/copresence.html |
| @@ -0,0 +1,63 @@ |
| +<!DOCTYPE HTML> |
| + |
|
Dan Beam
2014/12/08 22:41:59
if you don't have an <html> tag, where does [dir]
Charlie
2014/12/08 23:10:45
It doesn't. But I put it back.
|
| +<meta charset="utf-8"> |
| +<title i18n-content="title"></title> |
| +<link rel="stylesheet" href="chrome://copresence/copresence.css"> |
| +<script src="chrome://resources/js/load_time_data.js"></script> |
| +<script src="chrome://resources/js/util.js"></script> |
| +<script src="chrome://copresence/copresence.js"></script> |
| +<script src="chrome://copresence/strings.js"></script> |
|
Dan Beam
2014/12/08 22:41:59
nit: can these be at the bottom of the page?
Charlie
2014/12/08 23:10:45
Done.
|
| + |
| +<header> |
| + <h1 i18n-content="title"></h1> |
| +</header> |
| + |
| +<main> |
| + <section> |
| + <h2 i18n-content="directives_title"></h2> |
| + <table class="directive-table" id="directives-table"> |
|
Dan Beam
2014/12/08 22:41:59
nit: what's the advantage to using a <table> over
Charlie
2014/12/08 23:10:45
Only that I already know how to use tables :-) Wou
|
| + <thead> |
| + <tr> |
| + <td i18n-content="directive_type"> |
| + <td i18n-content="token_medium"> |
| + <td i18n-content="duration"> |
| + <td class="spacer"> |
| + <tbody> |
| + </table> |
| + </section> |
| + |
| + <section> |
| + <h2 i18n-content="sent_tokens_title"></h2> |
| + <table class="token-table" id="sent-tokens-table"> |
|
Dan Beam
2014/12/08 22:41:59
nit: arguably don't put "-table" in the class, but
Charlie
2014/12/08 23:10:45
Done.
|
| + <thead> |
| + <tr> |
| + <td i18n-content="token_id"> |
| + <td i18n-content="token_status"> |
| + <td i18n-content="token_medium"> |
| + <td i18n-content="token_send_time"> |
| + <td class="spacer"> |
| + <tbody> |
| + </table> |
| + </section> |
| + |
| + <section> |
| + <h2 i18n-content="received_tokens_title"></h2> |
| + <table class="token-table" id="received-tokens-table"> |
| + <thead> |
| + <tr> |
| + <td i18n-content="token_id"> |
| + <td i18n-content="token_status"> |
| + <td i18n-content="token_medium"> |
| + <td i18n-content="token_receive_time"> |
| + <td class="spacer"> |
| + <tbody> |
| + </table> |
| + </section> |
| + |
| + <!-- TODO(ckehoe): Add server calls --> |
|
Dan Beam
2014/12/08 22:41:59
nit: end comments with .
Charlie
2014/12/08 23:10:45
Done.
|
| + |
| + <!-- TODO(ckehoe): Add GCM pings --> |
| + |
| +</main> |
| + |
| +<script src="chrome://resources/js/i18n_template2.js"></script> |
