Chromium Code Reviews Chromium Code Reviews
Issue 734243003:
Adding the chrome://copresence page (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@state| OLD | NEW |
|---|---|
| (Empty) | |
| 1 <!DOCTYPE HTML> | |
| 2 | |
|
Dan Beam
2014/12/08 22:41:59
if you don't have an <html> tag, where does [dir]
Charlie
2014/12/08 23:10:45
It doesn't. But I put it back.
| |
| 3 <meta charset="utf-8"> | |
| 4 <title i18n-content="title"></title> | |
| 5 <link rel="stylesheet" href="chrome://copresence/copresence.css"> | |
| 6 <script src="chrome://resources/js/load_time_data.js"></script> | |
| 7 <script src="chrome://resources/js/util.js"></script> | |
| 8 <script src="chrome://copresence/copresence.js"></script> | |
| 9 <script src="chrome://copresence/strings.js"></script> | |
|
Dan Beam
2014/12/08 22:41:59
nit: can these be at the bottom of the page?
Charlie
2014/12/08 23:10:45
Done.
| |
| 10 | |
| 11 <header> | |
| 12 <h1 i18n-content="title"></h1> | |
| 13 </header> | |
| 14 | |
| 15 <main> | |
| 16 <section> | |
| 17 <h2 i18n-content="directives_title"></h2> | |
| 18 <table class="directive-table" id="directives-table"> | |
|
Dan Beam
2014/12/08 22:41:59
nit: what's the advantage to using a <table> over
Charlie
2014/12/08 23:10:45
Only that I already know how to use tables :-) Wou
| |
| 19 <thead> | |
| 20 <tr> | |
| 21 <td i18n-content="directive_type"> | |
| 22 <td i18n-content="token_medium"> | |
| 23 <td i18n-content="duration"> | |
| 24 <td class="spacer"> | |
| 25 <tbody> | |
| 26 </table> | |
| 27 </section> | |
| 28 | |
| 29 <section> | |
| 30 <h2 i18n-content="sent_tokens_title"></h2> | |
| 31 <table class="token-table" id="sent-tokens-table"> | |
|
Dan Beam
2014/12/08 22:41:59
nit: arguably don't put "-table" in the class, but
Charlie
2014/12/08 23:10:45
Done.
| |
| 32 <thead> | |
| 33 <tr> | |
| 34 <td i18n-content="token_id"> | |
| 35 <td i18n-content="token_status"> | |
| 36 <td i18n-content="token_medium"> | |
| 37 <td i18n-content="token_send_time"> | |
| 38 <td class="spacer"> | |
| 39 <tbody> | |
| 40 </table> | |
| 41 </section> | |
| 42 | |
| 43 <section> | |
| 44 <h2 i18n-content="received_tokens_title"></h2> | |
| 45 <table class="token-table" id="received-tokens-table"> | |
| 46 <thead> | |
| 47 <tr> | |
| 48 <td i18n-content="token_id"> | |
| 49 <td i18n-content="token_status"> | |
| 50 <td i18n-content="token_medium"> | |
| 51 <td i18n-content="token_receive_time"> | |
| 52 <td class="spacer"> | |
| 53 <tbody> | |
| 54 </table> | |
| 55 </section> | |
| 56 | |
| 57 <!-- TODO(ckehoe): Add server calls --> | |
|
Dan Beam
2014/12/08 22:41:59
nit: end comments with .
Charlie
2014/12/08 23:10:45
Done.
| |
| 58 | |
| 59 <!-- TODO(ckehoe): Add GCM pings --> | |
| 60 | |
| 61 </main> | |
| 62 | |
| 63 <script src="chrome://resources/js/i18n_template2.js"></script> | |
| OLD | NEW |
