Allow stepping into Promise handlers.

Allow stepping into Promise handlers.

BUG=chromium:432468
R=yangguo@chromium.org, adamk@chromium.org, arv@chromium.org
LOG=N

Committed: https://chromium.googlesource.com/v8/v8/+/35f10bacd454cd145d4fe9ba9d65f263ad7e50ab

[Yang, 2014-11-17 19:41:02]

https://codereview.chromium.org/734163002/diff/1/src/promise.js
File src/promise.js (right):

https://codereview.chromium.org/734163002/diff/1/src/promise.js#newcode276
src/promise.js:276: if (DEBUG_IS_ACTIVE &&
%DebugCallbackSupportsStepping(onReject)) {
This conditional is used in a lot of places now. Do we want to introduce its own
macro in macros.py?

[aandrey, 2014-11-18 09:07:20]

On 2014/11/17 19:41:02, Yang wrote:
> https://codereview.chromium.org/734163002/diff/1/src/promise.js
> File src/promise.js (right):
> 
> https://codereview.chromium.org/734163002/diff/1/src/promise.js#newcode276
> src/promise.js:276: if (DEBUG_IS_ACTIVE &&
> %DebugCallbackSupportsStepping(onReject)) {
> This conditional is used in a lot of places now. Do we want to introduce its
own
> macro in macros.py?

Done.

[Yang, 2014-11-18 09:10:22]

On 2014/11/18 09:07:20, aandrey wrote:
> On 2014/11/17 19:41:02, Yang wrote:
> > https://codereview.chromium.org/734163002/diff/1/src/promise.js
> > File src/promise.js (right):
> > 
> > https://codereview.chromium.org/734163002/diff/1/src/promise.js#newcode276
> > src/promise.js:276: if (DEBUG_IS_ACTIVE &&
> > %DebugCallbackSupportsStepping(onReject)) {
> > This conditional is used in a lot of places now. Do we want to introduce its
> own
> > macro in macros.py?
> 
> Done.

lgtm.

[Yang, 2014-11-18 09:10:35]

On 2014/11/18 09:10:22, Yang wrote:
> On 2014/11/18 09:07:20, aandrey wrote:
> > On 2014/11/17 19:41:02, Yang wrote:
> > > https://codereview.chromium.org/734163002/diff/1/src/promise.js
> > > File src/promise.js (right):
> > > 
> > > https://codereview.chromium.org/734163002/diff/1/src/promise.js#newcode276
> > > src/promise.js:276: if (DEBUG_IS_ACTIVE &&
> > > %DebugCallbackSupportsStepping(onReject)) {
> > > This conditional is used in a lot of places now. Do we want to introduce
its
> > own
> > > macro in macros.py?
> > 
> > Done.
> 
> lgtm.

btw CQ works for V8 now!

[aandrey, 2014-11-18 09:21:27]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-11-18 09:22:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/734163002/20001

[commit-bot: I haz the power, 2014-11-18 09:50:20]

Committed patchset #2 (id:20001)

[arv (Not doing code reviews), 2014-11-18 18:51:08]

LGTM

https://codereview.chromium.org/734163002/diff/20001/src/debug.cc
File src/debug.cc (right):

https://codereview.chromium.org/734163002/diff/20001/src/debug.cc#newcode1203
src/debug.cc:1203: if (function->IsFromNativeScript()) return;
Maybe this should have been a DCHECK instead. I think all the callers already
try to handle this.

https://codereview.chromium.org/734163002/diff/20001/test/mjsunit/es6/debug-s...
File test/mjsunit/es6/debug-stepin-promises.js (right):

https://codereview.chromium.org/734163002/diff/20001/test/mjsunit/es6/debug-s...
test/mjsunit/es6/debug-stepin-promises.js:9: var break_count = 0;
no underscores in js

https://codereview.chromium.org/734163002/diff/20001/test/mjsunit/es6/debug-s...
test/mjsunit/es6/debug-stepin-promises.js:45: .then(undefined, promise3)
or

.catch(promise3)

https://codereview.chromium.org/734163002/diff/20001/test/mjsunit/es6/debug-s...
test/mjsunit/es6/debug-stepin-promises.js:51: {
{ on previous line

[aandrey, 2014-11-19 11:41:27]

https://codereview.chromium.org/734163002/diff/20001/src/debug.cc
File src/debug.cc (right):

https://codereview.chromium.org/734163002/diff/20001/src/debug.cc#newcode1203
src/debug.cc:1203: if (function->IsFromNativeScript()) return;
On 2014/11/18 18:51:08, arv wrote:
> Maybe this should have been a DCHECK instead. I think all the callers already
> try to handle this.

Nope, only two places out of 7-8 in this file. One check I removed at line 1255,
also should remove at line 1229 (which is also not correct before calling
FloodWithOneShotGeneric)

https://codereview.chromium.org/734163002/diff/20001/test/mjsunit/es6/debug-s...
File test/mjsunit/es6/debug-stepin-promises.js (right):

https://codereview.chromium.org/734163002/diff/20001/test/mjsunit/es6/debug-s...
test/mjsunit/es6/debug-stepin-promises.js:51: {
On 2014/11/18 18:51:08, arv wrote:
> { on previous line

Addressed in https://codereview.chromium.org/739523002/