Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: src/debug.cc

Issue 734163002: Allow stepping into Promise handlers. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: addressed Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/macros.py » ('j') | test/mjsunit/es6/debug-stepin-promises.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug.cc
diff --git a/src/debug.cc b/src/debug.cc
index 3029adba9d53403677ac35ed4ce05ba2ac7dfde3..f5c2cbb2d7d504662ac7b40039e179720fb79da2 100644
--- a/src/debug.cc
+++ b/src/debug.cc
@@ -1199,6 +1199,9 @@ void Debug::ClearAllBreakPoints() {
void Debug::FloodWithOneShot(Handle<JSFunction> function,
BreakLocatorType type) {
+ // Do not ever break in native functions.
+ if (function->IsFromNativeScript()) return;
arv (Not doing code reviews) 2014/11/18 18:51:08 Maybe this should have been a DCHECK instead. I th
aandrey 2014/11/19 11:41:27 Nope, only two places out of 7-8 in this file. One
+
PrepareForBreakPoints();
// Make sure the function is compiled and has set up the debug info.
@@ -1249,7 +1252,7 @@ void Debug::FloodWithOneShotGeneric(Handle<JSFunction> function,
FloodBoundFunctionWithOneShot(function);
} else if (function->shared()->is_default_constructor()) {
FloodDefaultConstructorWithOneShot(function);
- } else if (!function->IsFromNativeScript()) {
+ } else {
Isolate* isolate = function->GetIsolate();
// Don't allow step into functions in the native context.
if (function->shared()->code() ==
« no previous file with comments | « no previous file | src/macros.py » ('j') | test/mjsunit/es6/debug-stepin-promises.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698