Source/core/animation/AnimationTimeline.cpp - Issue 734003002: Revert of Animations: Disable compositor when timeline playback rate is set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/AnimationTimeline.cpp

Issue 734003002: Revert of Animations: Disable compositor when timeline playback rate is set (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/animation/AnimationTimeline.cpp

diff --git a/Source/core/animation/AnimationTimeline.cpp b/Source/core/animation/AnimationTimeline.cpp

index df55992547e80a13d34cfea612165b303b115931..643a29e0c26a01abc53642435d015adc5d1c6f4a 100644

--- a/Source/core/animation/AnimationTimeline.cpp

+++ b/Source/core/animation/AnimationTimeline.cpp

@@ -236,12 +236,10 @@

void AnimationTimeline::setPlaybackRate(double playbackRate)

{

+ // FIXME: need to invalidate compositor animations

m_currentTimeSnapshot = currentTimeInternal();

m_rawCurrentTimeSnapshot = m_document->animationClock().currentTime() - zeroTime();

m_playbackRate = playbackRate;

- for (auto& player : m_players) {

- player->setCompositorPending(true);

- }

}

double AnimationTimeline::playbackRate() const

« no previous file with comments | « Source/core/animation/AnimationPlayer.cpp ('k') | no next file » | no next file with comments »