Source/core/animation/AnimationPlayer.cpp - Issue 734003002: Revert of Animations: Disable compositor when timeline playback rate is set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/AnimationPlayer.cpp

Issue 734003002: Revert of Animations: Disable compositor when timeline playback rate is set (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/animation/AnimationPlayer.cpp

diff --git a/Source/core/animation/AnimationPlayer.cpp b/Source/core/animation/AnimationPlayer.cpp

index 2152892b7c2c7f012ae131232aa9125afd68bc1b..6d5716534fb012a9d4b6339cb04c0a6dc8c82075 100644

--- a/Source/core/animation/AnimationPlayer.cpp

+++ b/Source/core/animation/AnimationPlayer.cpp

@@ -599,8 +599,7 @@

bool AnimationPlayer::canStartAnimationOnCompositor()

{

- // FIXME: Timeline playback rates should be compositable

- if (m_playbackRate == 0 || (std::isinf(sourceEnd()) && m_playbackRate < 0) || (timeline() && timeline()->playbackRate() != 1))

+ if (m_playbackRate == 0 || (std::isinf(sourceEnd()) && m_playbackRate < 0))

return false;

return m_timeline && m_content && m_content->isAnimation() && playing();

« no previous file with comments | « no previous file | Source/core/animation/AnimationTimeline.cpp » ('j') | no next file with comments »