components/password_manager/core/browser/password_manager_client.cc - Issue 733953002: Do not save passwords if the landing page has HTTP status 5xx or 4xx

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_client.cc

Issue 733953002: Do not save passwords if the landing page has HTTP status 5xx or 4xx (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing Vaclav's review comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/common/save_password_progress_logger.cc ('K') | « components/password_manager/core/browser/password_manager_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_client.cc

diff --git a/components/password_manager/core/browser/password_manager_client.cc b/components/password_manager/core/browser/password_manager_client.cc

index b3b07c9951f8ff3749e1b46a8bdf0ad55c458cb4..8509c76e30c0a2446b151800cef39984b47321f8 100644

--- a/components/password_manager/core/browser/password_manager_client.cc

+++ b/components/password_manager/core/browser/password_manager_client.cc

@@ -35,6 +35,10 @@ bool PasswordManagerClient::IsLoggingActive() const {

return false;

}

+bool PasswordManagerClient::WasLastNavigationHTTPError() const {

+ return false;

PasswordStore::AuthorizationPromptPolicy

PasswordManagerClient::GetAuthorizationPromptPolicy(

const autofill::PasswordForm& form) {