components/autofill/core/common/save_password_progress_logger.cc - Issue 733953002: Do not save passwords if the landing page has HTTP status 5xx or 4xx

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/save_password_progress_logger.cc

Issue 733953002: Do not save passwords if the landing page has HTTP status 5xx or 4xx (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing Vaclav's review comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/common/save_password_progress_logger.h ('K') | « components/autofill/core/common/save_password_progress_logger.h ('k') | components/password_manager/core/browser/password_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/save_password_progress_logger.cc

diff --git a/components/autofill/core/common/save_password_progress_logger.cc b/components/autofill/core/common/save_password_progress_logger.cc

index ee2d16eb5f7a8a874a6dc819f244d55b4f0846bf..f99fa5f2e64590b76e11f6110329288d00dda7f0 100644

--- a/components/autofill/core/common/save_password_progress_logger.cc

+++ b/components/autofill/core/common/save_password_progress_logger.cc

@@ -165,6 +165,10 @@ std::string GetStringFromID(SavePasswordProgressLogger::StringID id) {

return "wait_for_username";

case SavePasswordProgressLogger::STRING_LOGINMODELOBSERVER_PRESENT:

return "Instances of LoginModelObserver may be present";

+ case SavePasswordProgressLogger::STRING_WAS_LAST_NAVIGATION_HTTP_ERROR:

+ return "ChromePasswordManagerClient::WasLastNavigationHTTPError";

+ case SavePasswordProgressLogger::STRING_HTTP_STATUS_CODE:

+ return "HTTP Status Code for Landing Page";

vabr (Chromium) 2014/11/18 10:10:11 nit: No need to capitalise non-names. Please write

Sunil Ratnu 2014/11/18 12:58:39 Done.

case SavePasswordProgressLogger::STRING_INVALID:

return "INVALID";

// Intentionally no default: clause here -- all IDs need to get covered.