components/autofill/core/common/save_password_progress_logger.h - Issue 733953002: Do not save passwords if the landing page has HTTP status 5xx or 4xx

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/save_password_progress_logger.h

Issue 733953002: Do not save passwords if the landing page has HTTP status 5xx or 4xx (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing Vaclav's review comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_manager_browsertest.cc ('K') | « chrome/test/data/password/password_form.html ('k') | components/autofill/core/common/save_password_progress_logger.cc » ('j') | components/autofill/core/common/save_password_progress_logger.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/save_password_progress_logger.h

diff --git a/components/autofill/core/common/save_password_progress_logger.h b/components/autofill/core/common/save_password_progress_logger.h

index 2ba0c4883a37d69b239179f52c527fed9d847ad9..04fbfe979592aaa36baf34a08aa96c5e3a06b4dc 100644

--- a/components/autofill/core/common/save_password_progress_logger.h

+++ b/components/autofill/core/common/save_password_progress_logger.h

@@ -100,6 +100,8 @@ class SavePasswordProgressLogger {

STRING_PASSWORDMANAGER_AUTOFILL,

STRING_WAIT_FOR_USERNAME,

STRING_LOGINMODELOBSERVER_PRESENT,

+ STRING_WAS_LAST_NAVIGATION_HTTP_ERROR,

vabr (Chromium) 2014/11/18 10:10:11 nit: Please be consistent with the rest of names a

Sunil Ratnu 2014/11/18 12:58:39 Done.

+ STRING_HTTP_STATUS_CODE,

STRING_INVALID, // Represents a string returned in a case of an error.

STRING_MAX = STRING_INVALID

};