Do not save passwords if the landing page has HTTP status 5xx or 4xx

chrome/browser/password_manager/chrome_password_manager_client.cc

Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index ab2f0d809b36cca89f7ca3ab0c5df4836e784696..2c3f9a4073ad739c4b772b6ce1a1c7dcfd55460e 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -290,6 +290,18 @@ bool ChromePasswordManagerClient::IsLoggingActive() const {
   return can_use_log_router_ && !web_contents()->GetWebUI();
 }
 
+bool ChromePasswordManagerClient::WasLastNavigationHTTPError() const {
+  DCHECK(web_contents());

[vabr (Chromium), 2014/11/17 15:32:15]

Please create here an instance of BrowserSavePasswordProgressLogger and log:
(1) the name of this method (via LogMessage)
(2) the HTTP status code number (if obtained, via LogNumber)

Only create the browser if IsLoggingActive() is true, and add new string IDs for
both new messages. Feel free to get inspiration from logging in, e.g.,
PasswordManager::ProvisionallySavePassword.

[Sunil Ratnu, 2014/11/18 06:40:05]

Done.

+  content::NavigationEntry* entry =
+      web_contents()->GetController().GetVisibleEntry();
+  if (!entry)
+    return false;
+  int http_status_code = entry->GetHttpStatusCode();
+  if (http_status_code >= 400 && http_status_code <= 600)

[vabr (Chromium), 2014/11/17 15:32:15]

Please change "<= 600" to "< 600".
There does not seem to be a HTTP 600 status code, but if somebody later
introduces the 6xx family of codes, the code should not make false assumptions
about it.

[Sunil Ratnu, 2014/11/18 06:40:05]

Done.

+    return true;
+  return false;
+}
+
 // static
 password_manager::PasswordGenerationManager*
 ChromePasswordManagerClient::GetGenerationManagerFromWebContents(