content/browser/service_worker/service_worker_dispatcher_host.cc - Issue 733703002: Make sure message ports that are transferred to a serviceworker end up in the right process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.cc

Issue 733703002: Make sure message ports that are transferred to a serviceworker end up in the right process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@service-worker-message-port-transfer

Patch Set: fix test compile Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/embedded_worker_test_helper.cc ('k') | content/browser/service_worker/service_worker_version.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_dispatcher_host.cc

diff --git a/content/browser/service_worker/service_worker_dispatcher_host.cc b/content/browser/service_worker/service_worker_dispatcher_host.cc

index 8f00707381f1412fbe51215e6667fa579f972f16..009cbe917edcda483ce1bf623c0ce1b846967754 100644

--- a/content/browser/service_worker/service_worker_dispatcher_host.cc

+++ b/content/browser/service_worker/service_worker_dispatcher_host.cc

@@ -122,7 +122,7 @@ void ServiceWorkerDispatcherHost::Init(

context_wrapper_ = context_wrapper;

GetContext()->embedded_worker_registry()->AddChildProcessSender(

- render_process_id_, this);

+ render_process_id_, this, message_port_message_filter_);

}

void ServiceWorkerDispatcherHost::OnFilterAdded(IPC::Sender* sender) {

@@ -470,13 +470,8 @@ void ServiceWorkerDispatcherHost::OnPostMessageToWorker(

return;

}

- std::vector<int> new_routing_ids;

- message_port_message_filter_->UpdateMessagePortsWithNewRoutes(

- sent_message_port_ids, &new_routing_ids);

- handle->version()->SendMessage(

- ServiceWorkerMsg_MessageToWorker(message,

- sent_message_port_ids,

- new_routing_ids),

+ handle->version()->DispatchMessageEvent(

+ message, sent_message_port_ids,

base::Bind(&ServiceWorkerUtils::NoOpStatusCallback));

}