content/browser/service_worker/embedded_worker_test_helper.cc - Issue 733703002: Make sure message ports that are transferred to a serviceworker end up in the right process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/embedded_worker_test_helper.cc

Issue 733703002: Make sure message ports that are transferred to a serviceworker end up in the right process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@service-worker-message-port-transfer

Patch Set: fix test compile Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/embedded_worker_registry.cc ('k') | content/browser/service_worker/service_worker_dispatcher_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/embedded_worker_test_helper.cc

diff --git a/content/browser/service_worker/embedded_worker_test_helper.cc b/content/browser/service_worker/embedded_worker_test_helper.cc

index abc0c2b5c88e0b63f6e5c9f7938d3e9b4c016692..4669069e8527f5dda47990b00cdc8517208d3e79 100644

--- a/content/browser/service_worker/embedded_worker_test_helper.cc

+++ b/content/browser/service_worker/embedded_worker_test_helper.cc

@@ -33,7 +33,7 @@ EmbeddedWorkerTestHelper::EmbeddedWorkerTestHelper(int mock_render_process_id)

NULL,

NULL);

wrapper_->process_manager()->SetProcessIdForTest(mock_render_process_id);

- registry()->AddChildProcessSender(mock_render_process_id, this);

+ registry()->AddChildProcessSender(mock_render_process_id, this, nullptr);

}

EmbeddedWorkerTestHelper::~EmbeddedWorkerTestHelper() {

@@ -44,7 +44,7 @@ EmbeddedWorkerTestHelper::~EmbeddedWorkerTestHelper() {

void EmbeddedWorkerTestHelper::SimulateAddProcessToPattern(

const GURL& pattern,

int process_id) {

- registry()->AddChildProcessSender(process_id, this);

+ registry()->AddChildProcessSender(process_id, this, nullptr);

wrapper_->process_manager()->AddProcessReferenceToPattern(

pattern, process_id);

}