Getting rid of more (FX_LPCWSTR) casts and fixing two bugs revealed by this.

core/src/fxcrt/fx_xml_parser.cpp

Index: core/src/fxcrt/fx_xml_parser.cpp
diff --git a/core/src/fxcrt/fx_xml_parser.cpp b/core/src/fxcrt/fx_xml_parser.cpp
index 3608a74a93365ba814e619bc64e09583feededf4..4a0b9a1d4ff894624d71a6bb3e71d257ec83ea40 100644
--- a/core/src/fxcrt/fx_xml_parser.cpp
+++ b/core/src/fxcrt/fx_xml_parser.cpp
@@ -672,7 +672,7 @@ FX_BOOL CXML_Element::GetAttrValue(FX_BSTR name, CFX_WideString& attribute) cons
     FX_XML_SplitQualifiedName(name, bsSpace, bsName);
     const CFX_WideString* pValue = m_AttrMap.Lookup(bsSpace, bsName);

[Tom Sepez, 2014/11/17 18:43:15]

nit: some reason this doesn't just call into the method below it now that the
parameter has been split to match what is expected below?

[brucedawson, 2014/11/17 18:52:02]

Could do that, if there aren't any additional risks associated with making that
change.

Good also (I think) replace the assignment to attribute with:

    attribute = *pValue;

That seems like it is what is actually wanted, but I'm not certain.

     if (pValue) {
-        attribute = CFX_WideString((FX_LPCWSTR)pValue, pValue->GetLength());
+        attribute = CFX_WideString(pValue->c_str(), pValue->GetLength());
         return TRUE;
     }
     return FALSE;
@@ -681,7 +681,7 @@ FX_BOOL CXML_Element::GetAttrValue(FX_BSTR space, FX_BSTR name, CFX_WideString&
 {
     const CFX_WideString* pValue = m_AttrMap.Lookup(space, name);
     if (pValue) {
-        attribute = CFX_WideString((FX_LPCWSTR)pValue, pValue->GetLength());
+        attribute = CFX_WideString(pValue->c_str(), pValue->GetLength());
         return TRUE;
     }
     return FALSE;