Getting rid of more (FX_LPCWSTR) casts and fixing two bugs revealed by this.

core/src/fxcrt/fx_xml_parser.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/fxcrt/fx_xml.h"
 #include "xml_int.h"
 CXML_Parser::~CXML_Parser()
 {
@@ skipping 652 matching lines @@
 FX_BOOL CXML_Element::HasAttr(FX_BSTR name) const
 {
     CFX_ByteStringC bsSpace, bsName;
     FX_XML_SplitQualifiedName(name, bsSpace, bsName);
     return m_AttrMap.Lookup(bsSpace, bsName) != NULL;
 }
 FX_BOOL CXML_Element::GetAttrValue(FX_BSTR name, CFX_WideString& attribute) const
 {
     CFX_ByteStringC bsSpace, bsName;
     FX_XML_SplitQualifiedName(name, bsSpace, bsName);
     const CFX_WideString* pValue = m_AttrMap.Lookup(bsSpace, bsName);

[Tom Sepez, 2014/11/17 18:43:15]

nit: some reason this doesn't just call into the method below it now that the
parameter has been split to match what is expected below?

[brucedawson, 2014/11/17 18:52:02]

Could do that, if there aren't any additional risks associated with making that
change.

Good also (I think) replace the assignment to attribute with:

    attribute = *pValue;

That seems like it is what is actually wanted, but I'm not certain.

     if (pValue) {
-        attribute = CFX_WideString((FX_LPCWSTR)pValue, pValue->GetLength());
+        attribute = CFX_WideString(pValue->c_str(), pValue->GetLength());
         return TRUE;
     }
     return FALSE;
 }
 FX_BOOL CXML_Element::GetAttrValue(FX_BSTR space, FX_BSTR name, CFX_WideString& attribute) const
 {
     const CFX_WideString* pValue = m_AttrMap.Lookup(space, name);
     if (pValue) {
-        attribute = CFX_WideString((FX_LPCWSTR)pValue, pValue->GetLength());
+        attribute = CFX_WideString(pValue->c_str(), pValue->GetLength());
         return TRUE;
     }
     return FALSE;
 }
 FX_BOOL CXML_Element::GetAttrInteger(FX_BSTR name, int& attribute) const
 {
     CFX_ByteStringC bsSpace, bsName;
     FX_XML_SplitQualifiedName(name, bsSpace, bsName);
     const CFX_WideString* pwsValue = m_AttrMap.Lookup(bsSpace, bsName);
     if (pwsValue) {
@@ skipping 165 matching lines @@
 }
 void CXML_AttrMap::RemoveAll()
 {
     if (!m_pMap) {
         return;
     }
     m_pMap->RemoveAll();
     delete m_pMap;
     m_pMap = NULL;
 }