Bump _WIN32_WINNT to 0x0603

Bump _WIN32_WINNT to 0x0603

R=ncbray@chromium.org
BUG=311488, 432748
Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=14099

[scottmg, 2014-11-14 22:19:46]

scottmg@chromium.org changed reviewers:
+ ncbray@chromium.org

[Nick Bray (chromium), 2014-11-14 22:37:46]

LGTM (that's the ID for 8.1), although I am not extremely knowledgeable about
how the Windows SDK works.

[scottmg, 2014-11-14 22:41:05]

I'm not sure if the uses of native_client/build/common.gypi care much -- the src
build/common.gypi is being changed here
https://codereview.chromium.org/720033003/ so I figured it made sense to keep
them the same.

[Nick Bray (chromium), 2014-11-14 22:43:35]

On 2014/11/14 22:41:05, scottmg wrote:
> I'm not sure if the uses of native_client/build/common.gypi care much -- the
src
> build/common.gypi is being changed here
> https://codereview.chromium.org/720033003/ so I figured it made sense to keep
> them the same.

Should the GN build be updated, too?
build/config/win/BUILD.gn
Right now it's dead, so it's not a clear call.

[scottmg, 2014-11-14 22:46:50]

Ah, thanks!

Done.

On Fri, Nov 14, 2014 at 2:43 PM, <ncbray@chromium.org> wrote:

> On 2014/11/14 22:41:05, scottmg wrote:
>
>> I'm not sure if the uses of native_client/build/common.gypi care much --
>> the
>>
> src
>
>> build/common.gypi is being changed here
>> https://codereview.chromium.org/720033003/ so I figured it made sense to
>> keep
>> them the same.
>>
>
> Should the GN build be updated, too?
> build/config/win/BUILD.gn
> Right now it's dead, so it's not a clear call.
>
> https://codereview.chromium.org/733563003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[Nick Bray (chromium), 2014-11-14 23:47:03]

Still LGTM, although there's likely one more constant that needs to be changed.

https://codereview.chromium.org/733563003/diff/20001/build/config/win/BUILD.gn
File build/config/win/BUILD.gn (right):

https://codereview.chromium.org/733563003/diff/20001/build/config/win/BUILD.g...
build/config/win/BUILD.gn:17: "NTDDI_VERSION=0x06020000",
This too?

[scottmg, 2014-11-14 23:56:19]

https://codereview.chromium.org/733563003/diff/20001/build/config/win/BUILD.gn
File build/config/win/BUILD.gn (right):

https://codereview.chromium.org/733563003/diff/20001/build/config/win/BUILD.g...
build/config/win/BUILD.gn:17: "NTDDI_VERSION=0x06020000",
On 2014/11/14 23:47:03, Nick Bray (chromium) wrote:
> This too?

:( Done.

[scottmg, 2014-11-14 23:59:11]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-11-14 23:59:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/733563003/40001

[commit-bot: I haz the power, 2014-11-15 01:58:46]

Committed patchset #3 (id:40001) as 14099