Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: components/password_manager/core/common/password_manager_ui.h

Issue 733463003: Show user credentials chooser bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge with trunk Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/common/password_manager_ui.h
diff --git a/components/password_manager/core/common/password_manager_ui.h b/components/password_manager/core/common/password_manager_ui.h
index f09ccf7d2c50a53a467724562790795ab5664544..b7adbb4a5c7f52d8a4076609a7d3c0da774732d0 100644
--- a/components/password_manager/core/common/password_manager_ui.h
+++ b/components/password_manager/core/common/password_manager_ui.h
@@ -35,6 +35,13 @@ enum State {
// The user has blacklisted the site rendered in the current WebContents.
// The icon needs to be visible, in the blacklisted state.
BLACKLIST_STATE,
+
+ // The site has asked user to choose a credential. Now we need to display an
+ // Omnibox icon, and pop up a bubble.
+ CREDENTIAL_REQUEST_AND_BUBBLE_STATE,
+
+ // Credentials are pending, but we don't need to pop up a bubble.
+ CREDENTIAL_REQUEST_STATE,
};
// The position of a password item in a list of credentials.
@@ -49,6 +56,9 @@ enum PasswordItemPosition {
// Returns true if |state| represents a pending password.
bool IsPendingState(State state);
+// Returns true if |state| represents a pending credentials.
+bool IsCredentialsState(State state);
+
// Returns true if this state show cause the bubble to be shown without user
// interaction.
bool IsAutomaticDisplayState(State state);

Powered by Google App Engine
This is Rietveld 408576698