Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: components/password_manager/core/common/password_manager_ui.cc

Issue 733463003: Show user credentials chooser bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge with trunk Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/common/password_manager_ui.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/common/password_manager_ui.cc
diff --git a/components/password_manager/core/common/password_manager_ui.cc b/components/password_manager/core/common/password_manager_ui.cc
index b76394ed7f1a79662850d375e45ab29fd1a63903..c8c2da77552ca3b98c34dd4c70e4b46345c21263 100644
--- a/components/password_manager/core/common/password_manager_ui.cc
+++ b/components/password_manager/core/common/password_manager_ui.cc
@@ -14,9 +14,15 @@ bool IsPendingState(State state) {
state == PENDING_PASSWORD_STATE;
}
+bool IsCredentialsState(State state) {
+ return (state == CREDENTIAL_REQUEST_STATE ||
+ state == CREDENTIAL_REQUEST_AND_BUBBLE_STATE);
+}
+
bool IsAutomaticDisplayState(State state) {
return state == PENDING_PASSWORD_AND_BUBBLE_STATE ||
- state == CONFIRMATION_STATE;
+ state == CONFIRMATION_STATE ||
+ state == CREDENTIAL_REQUEST_AND_BUBBLE_STATE;
}
State GetEndStateForAutomaticState(State state) {
@@ -24,10 +30,10 @@ State GetEndStateForAutomaticState(State state) {
switch (state) {
case PENDING_PASSWORD_AND_BUBBLE_STATE:
return PENDING_PASSWORD_STATE;
- break;
case CONFIRMATION_STATE:
return MANAGE_STATE;
- break;
+ case CREDENTIAL_REQUEST_AND_BUBBLE_STATE:
+ return CREDENTIAL_REQUEST_STATE;
default:
NOTREACHED();
return INACTIVE_STATE;
« no previous file with comments | « components/password_manager/core/common/password_manager_ui.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698