Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 733443003: [DevTools] Used generated Inspector.detached in DevToolsHttpHandlerImpl (Closed)

Created:
6 years, 1 month ago by vkuzkokov
Modified:
6 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Used generated Inspector.detached in DevToolsHttpHandlerImpl BUG=405566 Committed: https://crrev.com/9c9d7fc86495c3482a3e0e4a088501ec5ad7dfa0 Cr-Commit-Position: refs/heads/master@{#305018}

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -16 lines) Patch
M content/browser/devtools/devtools_http_handler_impl.cc View 1 2 1 chunk +9 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vkuzkokov
6 years, 1 month ago (2014-11-20 13:50:47 UTC) #2
dgozman
lgtm https://codereview.chromium.org/733443003/diff/20001/content/browser/devtools/devtools_http_handler_impl.cc File content/browser/devtools/devtools_http_handler_impl.cc (right): https://codereview.chromium.org/733443003/diff/20001/content/browser/devtools/devtools_http_handler_impl.cc#newcode353 content/browser/devtools/devtools_http_handler_impl.cc:353: base::DictionaryValue notification; nit: notification unused. https://codereview.chromium.org/733443003/diff/20001/content/browser/devtools/devtools_http_handler_impl.cc#newcode355 content/browser/devtools/devtools_http_handler_impl.cc:355: base::Bind(&DevToolsAgentHostClientImpl::DispatchProtocolMessage, ...
6 years, 1 month ago (2014-11-20 14:29:14 UTC) #3
vkuzkokov
https://codereview.chromium.org/733443003/diff/20001/content/browser/devtools/devtools_http_handler_impl.cc File content/browser/devtools/devtools_http_handler_impl.cc (right): https://codereview.chromium.org/733443003/diff/20001/content/browser/devtools/devtools_http_handler_impl.cc#newcode353 content/browser/devtools/devtools_http_handler_impl.cc:353: base::DictionaryValue notification; On 2014/11/20 14:29:14, dgozman wrote: > nit: ...
6 years, 1 month ago (2014-11-20 14:47:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733443003/40001
6 years, 1 month ago (2014-11-20 14:48:50 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-20 16:13:32 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 16:14:21 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/9c9d7fc86495c3482a3e0e4a088501ec5ad7dfa0
Cr-Commit-Position: refs/heads/master@{#305018}

Powered by Google App Engine
This is Rietveld 408576698