[DevTools] Used generated Inspector.detached in DevToolsHttpHandlerImpl

content/browser/devtools/devtools_http_handler_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/files/file_util.h"
@@ skipping 331 matching lines @@
   }
 
   ~DevToolsAgentHostClientImpl() override {
     if (agent_host_.get())
       agent_host_->DetachClient();
   }
 
   void AgentHostClosed(DevToolsAgentHost* agent_host,
                        bool replaced_with_another_client) override {
     DCHECK(agent_host == agent_host_.get());
-    agent_host_ = NULL;
 
     base::DictionaryValue notification;

[dgozman, 2014/11/20 14:29:14]

nit: notification unused.

[vkuzkokov, 2014/11/20 14:47:35]

Done.

-    notification.SetString(
-        devtools::Inspector::detached::kParamReason,
+    devtools::inspector::Client client(
+        base::Bind(&DevToolsAgentHostClientImpl::DispatchProtocolMessage,

[dgozman, 2014/11/20 14:29:14]

Let's extract this bound function and call it |raw_message_callback|.

[vkuzkokov, 2014/11/20 14:47:35]

Done.

+                   base::Unretained(this), base::Unretained(agent_host)));
+    client.Detached(devtools::inspector::DetachedParams::Create()->set_reason(

[dgozman, 2014/11/20 14:29:13]

|inspector.Detached| would be nicer.

[vkuzkokov, 2014/11/20 14:47:35]

Done.

         replaced_with_another_client ?
-            "replaced_with_devtools" : "target_closed");
-    std::string response = DevToolsProtocol::CreateNotification(
-        devtools::Inspector::detached::kName,
-        notification.DeepCopy())->Serialize();
-    message_loop_->PostTask(
-        FROM_HERE,
-        base::Bind(&ServerWrapper::SendOverWebSocket,
-                   base::Unretained(server_wrapper_),
-                   connection_id_,
-                   response));
+            "replaced_with_devtools" : "target_closed"));
 
+    agent_host_ = nullptr;
     message_loop_->PostTask(
         FROM_HERE,
         base::Bind(&ServerWrapper::Close,
                    base::Unretained(server_wrapper_),
                    connection_id_));
   }
 
   void DispatchProtocolMessage(DevToolsAgentHost* agent_host,
                                const std::string& message) override {
     DCHECK(agent_host == agent_host_.get());
@@ skipping 753 matching lines @@
         id.c_str(),
         host);
     dictionary->SetString(
         kTargetDevtoolsFrontendUrlField, devtools_frontend_url);
   }
 
   return dictionary;
 }
 
 }  // namespace content