De-activate LayerAnimationControllers when all animations are WaitingForDeletion

De-activate LayerAnimationControllers when all animations are WaitingForDeletion

Animations that are in the WaitingForDeletion state cannot make any
further progress, so we do not need to tick LayerAnimationControllers that
only have such animations.

BUG=319557
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235657

[Ian Vollick, 2013-11-15 01:51:06]

On 2013/11/15 00:11:19, ajuma wrote:

lgtm. Nice test!

[ajuma, 2013-11-15 18:32:50]

PTAL.

https://codereview.chromium.org/73343002/diff/140001/cc/trees/layer_tree_host...
File cc/trees/layer_tree_host_unittest_animation.cc (left):

https://codereview.chromium.org/73343002/diff/140001/cc/trees/layer_tree_host...
cc/trees/layer_tree_host_unittest_animation.cc:870: OVERRIDE {
This needed to be changed, since this CL removes DispatchAddInstantAnimation in
LayerTreeTest. But there doesn't seem to be any way for this code to get reached
in this test, since we never call PostAddInstantAnimationToMainThread. So I've
removed this method altogether.

https://codereview.chromium.org/73343002/diff/140001/cc/trees/layer_tree_host...
File cc/trees/layer_tree_host_unittest_animation.cc (right):

https://codereview.chromium.org/73343002/diff/140001/cc/trees/layer_tree_host...
cc/trees/layer_tree_host_unittest_animation.cc:257: class
LayerTreeHostAnimationTestTickAnimationWhileBackgrounded
This test was flaking on the Windows trybots. Since the animation we were adding
was really short (0.000001 seconds), I suspect we were getting the following
sequence of events:
-animation added to main thread
-animation committed to impl thread
-animation ticked on the impl thread (num_animates_ is now 1)
-animation ticked again on the impl thread, finishing and moving into
WaitingForDeletion (num_animates_ is now 2)
-ThreadProxy::SetVisibleOnImplThread makes us non-visible, and we don't trigger
background ticking since there are no active animation controllers
-the test hangs since WillAnimateLayers is never called again

To fix this, I've increased the duration of the animation to 1 second (but note
that this shouldn't actually make the test take 1 second, since the test
finishes once we've ticked animations 3 times).

[Ian Vollick, 2013-11-15 18:40:29]

slgtm

On 2013/11/15 18:32:50, ajuma wrote:
> PTAL.
> 
>
https://codereview.chromium.org/73343002/diff/140001/cc/trees/layer_tree_host...
> File cc/trees/layer_tree_host_unittest_animation.cc (left):
> 
>
https://codereview.chromium.org/73343002/diff/140001/cc/trees/layer_tree_host...
> cc/trees/layer_tree_host_unittest_animation.cc:870: OVERRIDE {
> This needed to be changed, since this CL removes DispatchAddInstantAnimation
in
> LayerTreeTest. But there doesn't seem to be any way for this code to get
reached
> in this test, since we never call PostAddInstantAnimationToMainThread. So I've
> removed this method altogether.
K, cool.
> 
>
https://codereview.chromium.org/73343002/diff/140001/cc/trees/layer_tree_host...
> File cc/trees/layer_tree_host_unittest_animation.cc (right):
> 
>
https://codereview.chromium.org/73343002/diff/140001/cc/trees/layer_tree_host...
> cc/trees/layer_tree_host_unittest_animation.cc:257: class
> LayerTreeHostAnimationTestTickAnimationWhileBackgrounded
> This test was flaking on the Windows trybots. Since the animation we were
adding
> was really short (0.000001 seconds), I suspect we were getting the following
> sequence of events:
> -animation added to main thread
> -animation committed to impl thread
> -animation ticked on the impl thread (num_animates_ is now 1)
> -animation ticked again on the impl thread, finishing and moving into
> WaitingForDeletion (num_animates_ is now 2)
> -ThreadProxy::SetVisibleOnImplThread makes us non-visible, and we don't
trigger
> background ticking since there are no active animation controllers
> -the test hangs since WillAnimateLayers is never called again
> 
> To fix this, I've increased the duration of the animation to 1 second (but
note
> that this shouldn't actually make the test take 1 second, since the test
> finishes once we've ticked animations 3 times).
sg.

[commit-bot: I haz the power, 2013-11-17 21:55:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajuma@chromium.org/73343002/140001

[commit-bot: I haz the power, 2013-11-18 00:09:27]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-18 02:30:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajuma@chromium.org/73343002/140001

[commit-bot: I haz the power, 2013-11-18 08:10:18]

Change committed as 235657