Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 733273004: [Android] Tweak pull-to-refresh effect animation (Closed)

Created:
6 years, 1 month ago by jdduke (slow)
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Tweak the pull-to-refresh effect animation Modify pull-to-refresh drag movement, as well as the initial activation animation, to more closely align with the default Android platform effect. BUG=428429 Committed: https://crrev.com/15071e55a8971af71ac3518cd302254593f8814c Cr-Commit-Position: refs/heads/master@{#304931}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -56 lines) Patch
M content/browser/android/overscroll_refresh.cc View 16 chunks +97 lines, -56 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jdduke (slow)
aurimas@: PTAL, thanks. Noted the translation logic taken from https://cs.corp.google.com/#android/frameworks/support/v4/java/android/support/v4/widget/SwipeRefreshLayout.java.
6 years, 1 month ago (2014-11-19 21:33:33 UTC) #2
aurimas (slooooooooow)
lgtm
6 years, 1 month ago (2014-11-19 23:07:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733273004/1
6 years, 1 month ago (2014-11-19 23:12:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-19 23:55:38 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 23:56:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15071e55a8971af71ac3518cd302254593f8814c
Cr-Commit-Position: refs/heads/master@{#304931}

Powered by Google App Engine
This is Rietveld 408576698