Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 7331035: Implement API functions for handling the AccessorDescriptor (Closed)

Created:
9 years, 5 months ago by Peter Varga
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Implement API functions for handling the AccessorDescriptor Patch by Peter Varga. BUG=none TEST=cctest/test-api/DefineAndLookupGetterSetter

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -0 lines) Patch
M include/v8.h View 1 chunk +16 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +54 lines, -0 lines 0 comments Download
M src/handles.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/handles.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Peter Varga
9 years, 5 months ago (2011-07-11 10:58:03 UTC) #1
Mads Ager (chromium)
__defineGetter__ and friends are not part of the standard and i would prefer not to ...
9 years, 5 months ago (2011-07-12 07:09:41 UTC) #2
Peter Varga
9 years, 5 months ago (2011-07-12 08:40:13 UTC) #3
Thank you for the reply.

We are already using a similar solution for handling a property's getter/setter
but I just try to avoid the overhead of the "CompileAndRun" of a JS code with
this patch.
Since we store the "define_getter" function in a Persistent handle, the
destruction of the wrapper object causes more performance decrease.

After all I can accept the rejection because these AccessorDescriptor handler
functions actually are not part of the ECMA.

Powered by Google App Engine
This is Rietveld 408576698