chrome/common/extensions/docs/examples/tutorials/getstarted/popup.html - Issue 732943002: New Getting started example for extensions

Unified Diff: chrome/common/extensions/docs/examples/tutorials/getstarted/popup.html

Issue 732943002: New Getting started example for extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/examples/tutorials/getstarted/manifest.json ('k') | chrome/common/extensions/docs/examples/tutorials/getstarted/popup.js » ('j') | chrome/common/extensions/docs/examples/tutorials/getstarted/popup.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/examples/tutorials/getstarted/popup.html

diff --git a/chrome/common/extensions/docs/examples/tutorials/getstarted/popup.html b/chrome/common/extensions/docs/examples/tutorials/getstarted/popup.html

index f58540d5d551b4af8b13f63ad2c82b680ff36181..d4aa8980f60ec54697fbb040757015cb947a4528 100644

--- a/chrome/common/extensions/docs/examples/tutorials/getstarted/popup.html

+++ b/chrome/common/extensions/docs/examples/tutorials/getstarted/popup.html

@@ -4,16 +4,14 @@

<title>Getting Started Extension's Popup</title>

<style>

body {

- min-width: 357px;

- overflow-x: hidden;

+ font-family: "Segoe UI", "Lucida Grande", Tahoma, sans-serif;

not at google - send to devlin 2014/11/17 22:02:57 You shouldn't need fonts, we set these automatical

robwu 2014/11/17 22:26:11 Really? Also for the extension popup?

not at google - send to devlin 2014/11/17 23:14:03 Yes, we always set fonts. The options page stuff a

+ font-size: 100%;

}

- img {

- margin: 5px;

- border: 2px solid black;

- vertical-align: middle;

- width: 75px;

- height: 75px;

+ #status {

+ white-space: pre-line;

+ }

+ #image-result:not([src]) {

+ display: none;

}

not at google - send to devlin 2014/11/17 22:02:57 I thikn better would be to define a rule [hidden]

robwu 2014/11/17 22:26:11 Okay, I've added hidden to the <img>. Removed this

</style>

@@ -21,11 +19,13 @@

- JavaScript and HTML must be in separate files: see our Content Security

- Policy documentation[1] for details and explanation.

- - [1]: http://developer.chrome.com/extensions/contentSecurityPolicy.html

+ - [1]: https://developer.chrome.com/extensions/contentSecurityPolicy

-->

</head>

<body>

+ <div id="status"></div>

+ <img id="image-result">

</body>

</html>