chrome/common/extensions/docs/examples/tutorials/getstarted/popup.html - Issue 732943002: New Getting started example for extensions

Side by Side Diff: chrome/common/extensions/docs/examples/tutorials/getstarted/popup.html

Issue 732943002: New Getting started example for extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/common/extensions/docs/examples/tutorials/getstarted/manifest.json ('k') | chrome/common/extensions/docs/examples/tutorials/getstarted/popup.js » ('j') | chrome/common/extensions/docs/examples/tutorials/getstarted/popup.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Getting Started Extension's Popup</title>	4 <title>Getting Started Extension's Popup</title>

5 <style>	5 <style>

6 body {	6 body {

7 min-width: 357px;	7 font-family: "Segoe UI", "Lucida Grande", Tahoma, sans-serif;
	not at google - send to devlin 2014/11/17 22:02:57 You shouldn't need fonts, we set these automatical You shouldn't need fonts, we set these automatically now. Same for scaling, unless you really want 100% font size for some reason. robwu 2014/11/17 22:26:11 Really? Also for the extension popup? Show quoted text On 2014/11/17 22:02:57, kalman wrote: > You shouldn't need fonts, we set these automatically now. Really? Also for the extension popup? Show quoted text > > Same for scaling, unless you really want 100% font size for some reason. After a recent update, the fonts became much smaller than expected for one of my extensions. Choosing an explicit font size ensures that the extension continues to look as intended. not at google - send to devlin 2014/11/17 23:14:03 Yes, we always set fonts. The options page stuff a Show quoted text On 2014/11/17 22:26:11, robwu wrote: > On 2014/11/17 22:02:57, kalman wrote: > > You shouldn't need fonts, we set these automatically now. > > Really? Also for the extension popup? Yes, we always set fonts. The options page stuff additionally sets some form styling. Show quoted text > > > > > Same for scaling, unless you really want 100% font size for some reason. > > After a recent update, the fonts became much smaller than expected for one of my > extensions. Choosing an explicit font size ensures that the extension continues > to look as intended. Yes, probably that font change. It sets the size to whatever the "platform default" is (usually 75% apparently).
8 overflow-x: hidden;	8 font-size: 100%;

9 }	9 }

10	10 #status {

11 img {	11 white-space: pre-line;

12 margin: 5px;	12 }

13 border: 2px solid black;	13 #image-result:not([src]) {

14 vertical-align: middle;	14 display: none;

15 width: 75px;

16 height: 75px;

17 }	15 }
	not at google - send to devlin 2014/11/17 22:02:57 I thikn better would be to define a rule [hidden] I thikn better would be to define a rule [hidden] { display: none !important; } then explicitly set the img to be 'hidden', rather than magical 'src' matching properties. robwu 2014/11/17 22:26:11 Okay, I've added hidden to the <img>. Removed this Show quoted text On 2014/11/17 22:02:57, kalman wrote: > I thikn better would be to define a rule > > [hidden] { > display: none !important; > } > > then explicitly set the img to be 'hidden', rather than magical 'src' matching > properties. Okay, I've added hidden to the <img>. Removed this declaration (and did not put [hidden] back because it already hides by default).
18 </style>	16 </style>

19	17

20 <!--	18 <!--

21 - JavaScript and HTML must be in separate files: see our Content Security	19 - JavaScript and HTML must be in separate files: see our Content Security

22 - Policy documentation[1] for details and explanation.	20 - Policy documentation[1] for details and explanation.

23 -	21 -

24 - [1]: http://developer.chrome.com/extensions/contentSecurityPolicy.html	22 - [1]: https://developer.chrome.com/extensions/contentSecurityPolicy

25 -->	23 -->

26 <script src="popup.js"></script>	24 <script src="popup.js"></script>

27 </head>	25 </head>

28 <body>	26 <body>

	27 <div id="status"></div>

	28 <img id="image-result">

29 </body>	29 </body>

30 </html>	30 </html>

31	31

OLD	NEW